From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208AbdBCJ5A (ORCPT ); Fri, 3 Feb 2017 04:57:00 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44928 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753029AbdBCJ45 (ORCPT ); Fri, 3 Feb 2017 04:56:57 -0500 Date: Fri, 3 Feb 2017 10:56:45 +0100 From: Greg KH To: laurentiu.tudor@nxp.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, agraf@suse.de, arnd@arndb.de, ioana.ciornei@nxp.com, ruxandra.radulescu@nxp.com, bharat.bhushan@nxp.com, stuart.yoder@nxp.com, catalin.horghidan@nxp.com, leoyang.li@nxp.com, roy.pledge@nxp.com Subject: Re: [PATCH 2/9] staging: fsl-mc: fix device ref counting Message-ID: <20170203095645.GE24767@kroah.com> References: <20170201114329.21276-1-laurentiu.tudor@nxp.com> <20170201114329.21276-3-laurentiu.tudor@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170201114329.21276-3-laurentiu.tudor@nxp.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 01, 2017 at 05:43:22AM -0600, laurentiu.tudor@nxp.com wrote: > From: Laurentiu Tudor > > Drop unneeded get_device() call at device creation > and, as per documentation, drop reference count > after using device_find_child() return. > > Signed-off-by: Laurentiu Tudor > --- > drivers/staging/fsl-mc/bus/dprc-driver.c | 1 + > drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c > index 4e416d8..e4b0341 100644 > --- a/drivers/staging/fsl-mc/bus/dprc-driver.c > +++ b/drivers/staging/fsl-mc/bus/dprc-driver.c > @@ -188,6 +188,7 @@ static void dprc_add_new_devices(struct fsl_mc_device *mc_bus_dev, > child_dev = fsl_mc_device_lookup(obj_desc, mc_bus_dev); > if (child_dev) { > check_plugged_state_change(child_dev, obj_desc); > + put_device(&child_dev->dev); > continue; > } > > diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c > index cc20dc4..7c6a43b 100644 > --- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c > +++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c > @@ -537,7 +537,6 @@ int fsl_mc_device_add(struct dprc_obj_desc *obj_desc, > goto error_cleanup_dev; > } > > - (void)get_device(&mc_dev->dev); This implies that your device reference counting is totally wrong and messed up. Does this fix anything? Break anything? It should do something different now... thanks, greg k-h