From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752986AbdBCKdC (ORCPT ); Fri, 3 Feb 2017 05:33:02 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:49290 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752219AbdBCKdB (ORCPT ); Fri, 3 Feb 2017 05:33:01 -0500 Date: Fri, 3 Feb 2017 11:33:04 +0100 From: Greg Kroah-Hartman To: James Simmons Cc: devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH 10/60] staging: lustre: obdclass: add more info to sysfs version string Message-ID: <20170203103304.GA2600@kroah.com> References: <1485648328-2141-1-git-send-email-jsimmons@infradead.org> <1485648328-2141-11-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485648328-2141-11-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 28, 2017 at 07:04:38PM -0500, James Simmons wrote: > From: Andreas Dilger > > Update the sysfs "version" file to print "lustre: " with > the version number. > > Signed-off-by: Andreas Dilger > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5969 > Reviewed-on: http://review.whamcloud.com/16721 > Reviewed-by: James Simmons > Reviewed-by: Dmitry Eremin > Reviewed-by: Oleg Drokin > Signed-off-by: James Simmons > --- > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c > index 9f5e829..22e6d1f 100644 > --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c > +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c > @@ -208,7 +208,7 @@ struct miscdevice obd_psdev = { > static ssize_t version_show(struct kobject *kobj, struct attribute *attr, > char *buf) > { > - return sprintf(buf, "%s\n", LUSTRE_VERSION_STRING); > + return sprintf(buf, "lustre: %s\n", LUSTRE_VERSION_STRING); > } Why? You "know" this is lustre, why say it again? Doesn't this affect userspace tools? thanks, greg k-h