From: Andrew Lunn <andrew@lunn.ch>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: netdev@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-kernel@vger.kernel.org,
Murali Karicheri <m-karicheri2@ti.com>,
Sekhar Nori <nsekhar@ti.com>,
"David S . Miller" <davem@davemloft.net>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Mugunthan V N <mugunthanvnm@ti.com>
Subject: Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs
Date: Fri, 3 Feb 2017 18:10:31 +0100 [thread overview]
Message-ID: <20170203171031.GC15900@lunn.ch> (raw)
In-Reply-To: <20170203165237.22452-1-abrodkin@synopsys.com>
On Fri, Feb 03, 2017 at 07:52:37PM +0300, Alexey Brodkin wrote:
> Current implemntation returns ENODEV if device tree node for
> phy is absent. But in reality there're many boards with the one
> and only PHY on board and MACs that may find a PHY by querying
> MDIO bus. One good example is STMMAC.
Humm, not so sure about that. That check for an OF node has always
been there, since day one for this driver.
What has changed recently is where it looks for these device tree
properties. It used to wrongly look in the MAC node. It was changed to
look in the PHY node. So this is probably the reason you are having
problems.
Having said that, your patch looks O.K.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-02-03 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 16:52 [PATCH] net: phy: dp83867: Fix for automatically detected PHYs Alexey Brodkin
2017-02-03 17:10 ` Andrew Lunn [this message]
2017-02-03 17:30 ` Alexey Brodkin
2017-02-03 17:54 ` Andrew Lunn
2017-02-03 18:34 ` Florian Fainelli
2017-02-06 19:16 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203171031.GC15900@lunn.ch \
--to=andrew@lunn.ch \
--cc=Alexey.Brodkin@synopsys.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=m-karicheri2@ti.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox