From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751045AbdBCRKl (ORCPT ); Fri, 3 Feb 2017 12:10:41 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:55043 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828AbdBCRKj (ORCPT ); Fri, 3 Feb 2017 12:10:39 -0500 Date: Fri, 3 Feb 2017 18:10:31 +0100 From: Andrew Lunn To: Alexey Brodkin Cc: netdev@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, Murali Karicheri , Sekhar Nori , "David S . Miller" , Grygorii Strashko , Florian Fainelli , Mugunthan V N Subject: Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs Message-ID: <20170203171031.GC15900@lunn.ch> References: <20170203165237.22452-1-abrodkin@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170203165237.22452-1-abrodkin@synopsys.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 03, 2017 at 07:52:37PM +0300, Alexey Brodkin wrote: > Current implemntation returns ENODEV if device tree node for > phy is absent. But in reality there're many boards with the one > and only PHY on board and MACs that may find a PHY by querying > MDIO bus. One good example is STMMAC. Humm, not so sure about that. That check for an OF node has always been there, since day one for this driver. What has changed recently is where it looks for these device tree properties. It used to wrongly look in the MAC node. It was changed to look in the PHY node. So this is probably the reason you are having problems. Having said that, your patch looks O.K. Reviewed-by: Andrew Lunn Andrew