From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: lizefan@huawei.com, hannes@cmpxchg.org, mingo@redhat.com,
pjt@google.com, luto@amacapital.net, efault@gmx.de,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, lvenanci@redhat.com
Subject: Re: [PATCHSET for-4.11] cgroup: implement cgroup v2 thread mode
Date: Fri, 3 Feb 2017 15:59:55 -0500 [thread overview]
Message-ID: <20170203205955.GA9886@mtj.duckdns.org> (raw)
In-Reply-To: <20170203202048.GD6515@twins.programming.kicks-ass.net>
Hello, Peter.
On Fri, Feb 03, 2017 at 09:20:48PM +0100, Peter Zijlstra wrote:
> So my proposal was to do the inverse of what you propose here. Instead
> of marking special 'thread' subtrees, explicitly mark resource domains
> in the tree.
>
> So always allow arbitrary hierarchies and allow threads to be assigned
> to cgroups, as long as they're all in the same resource domain.
>
> Controllers that do not support things, fallback to mapping everything
> to the nearest resource domain.
That sounds counter-intuitive as all controllers can do resource
domains and only a subset of them can do thread mode. Also, thread
subtrees are necessarily a sub-hierarchy of a resource domain. Also,
expanding resource domains from the root after the trees are populated
would make the behaviors surprising as the resource domains that these
subtrees belong to would change dynamically.
In practice, how would this work? To enable memcg, the user has to
first create the subtree and then explicitly have to make that a
domain and then enable memcg? If so, that would be a completely
unnecessary deviation from the current behavior while not achieving
any more functionalities, right? It's just flipping the default value
the other way around and the default wouldn't be supported by many of
the controllers. I can't see how that is a better option.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-02-03 20:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 20:06 [PATCHSET for-4.11] cgroup: implement cgroup v2 thread mode Tejun Heo
2017-02-02 20:06 ` [PATCH 1/5] cgroup: reorganize cgroup.procs / task write path Tejun Heo
2017-02-02 20:06 ` [PATCH 2/5] cgroup: add @flags to css_task_iter_start() and implement CSS_TASK_ITER_PROCS Tejun Heo
2017-02-02 20:06 ` [PATCH 3/5] cgroup: introduce cgroup->proc_cgrp and threaded css_set handling Tejun Heo
2017-02-02 20:06 ` [PATCH 4/5] cgroup: implement CSS_TASK_ITER_THREADED Tejun Heo
2017-02-02 20:06 ` [PATCH 5/5] cgroup: implement cgroup v2 thread support Tejun Heo
2017-02-02 21:32 ` [PATCHSET for-4.11] cgroup: implement cgroup v2 thread mode Andy Lutomirski
2017-02-02 21:52 ` Tejun Heo
2017-02-03 21:10 ` Andy Lutomirski
2017-02-03 21:56 ` Tejun Heo
2017-02-06 9:50 ` Peter Zijlstra
2017-02-03 20:20 ` Peter Zijlstra
2017-02-03 20:59 ` Tejun Heo [this message]
2017-02-06 12:49 ` Peter Zijlstra
2017-02-08 23:08 ` Tejun Heo
2017-02-09 10:29 ` Peter Zijlstra
2017-02-10 15:45 ` Tejun Heo
2017-02-10 17:51 ` Peter Zijlstra
2017-02-12 5:05 ` Tejun Heo
2017-02-12 6:59 ` Mike Galbraith
2017-02-13 5:45 ` Mike Galbraith
2017-03-13 19:26 ` Tejun Heo
2017-03-14 14:45 ` Mike Galbraith
2017-02-14 10:35 ` Peter Zijlstra
2017-03-13 20:05 ` Tejun Heo
2017-03-21 12:39 ` Peter Zijlstra
2017-03-22 14:52 ` Peter Zijlstra
2017-02-09 13:07 ` Paul Turner
2017-02-09 14:47 ` Peter Zijlstra
2017-02-09 15:08 ` Mike Galbraith
[not found] ` <CAPM31RJaJjFwenC36Abij+EdzO3KBm-DEjQ_crSmzrtrrn2N2A@mail.gmail.com>
2017-02-13 5:28 ` Mike Galbraith
2017-02-10 15:46 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203205955.GA9886@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=efault@gmx.de \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=luto@amacapital.net \
--cc=lvenanci@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).