From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752658AbdBCVsC (ORCPT ); Fri, 3 Feb 2017 16:48:02 -0500 Received: from customer-85-204-195-167.ip4.gigabit.dk ([85.204.195.167]:57759 "EHLO customer-2a00-7660-0ca7-0000-0000-0000-0000-0b1b.ip6.gigabit.dk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752268AbdBCVsA (ORCPT ); Fri, 3 Feb 2017 16:48:00 -0500 Date: Fri, 3 Feb 2017 22:47:54 +0100 From: Rask Ingemann Lambertsen To: Chen-Yu Tsai Cc: Mark Rutland , devicetree , Liam Girdwood , Rob Herring , linux-kernel , Mark Brown , Lee Jones , linux-arm-kernel , Maxime Ripard Subject: Re: [PATCH 3/5] mfd: axp20x: Add support for the AXP808 PMIC Message-ID: <20170203214753.rbybkadomljcvtdg@localhost> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161104 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 02, 2017 at 03:23:33PM +0800, Chen-Yu Tsai wrote: > On Fri, Jan 27, 2017 at 5:25 AM, Rask Ingemann Lambertsen > wrote: [...] > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > > index 25115fe..2d3383e 100644 > > --- a/drivers/mfd/axp20x.c > > +++ b/drivers/mfd/axp20x.c [...] > > @@ -148,6 +149,13 @@ static const struct regmap_range axp806_writeable_ranges[] = { > > regmap_reg_range(AXP806_REG_ADDR_EXT, AXP806_REG_ADDR_EXT), > > }; > > > > +static const struct regmap_range axp808_writeable_ranges[] = { > > + regmap_reg_range(AXP20X_DATACACHE(0), AXP20X_DATACACHE(3)), > > + regmap_reg_range(AXP806_PWR_OUT_CTRL1, AXP806_CLDO3_V_CTRL), > > + regmap_reg_range(AXP20X_IRQ1_EN, AXP20X_IRQ2_EN), > > + regmap_reg_range(AXP20X_IRQ1_STATE, AXP20X_IRQ2_STATE), > > +}; > > + > > static const struct regmap_range axp806_volatile_ranges[] = { > > regmap_reg_range(AXP20X_IRQ1_STATE, AXP20X_IRQ2_STATE), > > }; > > @@ -162,6 +170,11 @@ static const struct regmap_access_table axp806_volatile_table = { > > .n_yes_ranges = ARRAY_SIZE(axp806_volatile_ranges), > > }; > > > > +static const struct regmap_access_table axp808_writeable_table = { > > + .yes_ranges = axp808_writeable_ranges, > > + .n_yes_ranges = ARRAY_SIZE(axp808_writeable_ranges), > > You could probably get away with using axp806_writeable_ranges, > and pass ARRAY_SIZE(axp808_writeable_ranges) - 1 for .n_yes_ranges. Assuming that register ranges not supported on the AXP808 are always at one end of the table, I think it will ease maintenance by avoiding duplicate data should entries be added or removed in the future. I'll put a comment above axp806_writeable_ranges to point out what's going on. > Or maybe the compiler figures out the 2 arrays share common data. It doesn't as of gcc 6.2.1. -- Rask Ingemann Lambertsen