From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752781AbdBCWTG (ORCPT ); Fri, 3 Feb 2017 17:19:06 -0500 Received: from mga01.intel.com ([192.55.52.88]:34323 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752376AbdBCWTE (ORCPT ); Fri, 3 Feb 2017 17:19:04 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,330,1477983600"; d="scan'208";a="60640601" From: Andi Kleen To: peterz@infradead.org Cc: alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, Andi Kleen , adrian.hunter@intel.com Subject: [PATCH 2/2] perf tools: Support end symbols with no size for filters Date: Fri, 3 Feb 2017 14:18:30 -0800 Message-Id: <20170203221830.22354-2-andi@firstfloor.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170203221830.22354-1-andi@firstfloor.org> References: <20170203221830.22354-1-andi@firstfloor.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen Currently a filter like --filter "filter _text / _end" doesn't work because _end doesn't have a size. The filter resolution always wants to use the end of the function as end. Allow this case by assuming the filter just spawns to the start of the end symbol when there is no size. This makes the above useful filter work. Cc: adrian.hunter@intel.com Signed-off-by: Andi Kleen --- tools/perf/util/auxtrace.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c index c5a6e0b12452..4c5ccb2b1298 100644 --- a/tools/perf/util/auxtrace.c +++ b/tools/perf/util/auxtrace.c @@ -1840,7 +1840,12 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt) if (err) return err; filt->size = start + size - filt->addr; - no_size = !!size; + /* + * When to has no size assume it's a end symbol. + * This allows filters like _text / _end + */ + if (size == 0) + filt->size = start - filt->addr; } /* The very last symbol in kallsyms does not imply a particular size */ -- 2.9.3