From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751562AbdBDRzY (ORCPT ); Sat, 4 Feb 2017 12:55:24 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:55670 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467AbdBDRzW (ORCPT ); Sat, 4 Feb 2017 12:55:22 -0500 Date: Sat, 4 Feb 2017 18:55:17 +0100 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , cphealy@gmail.com Subject: Re: [PATCH net-next 6/6] net: dsa: introduce bridge notifier Message-ID: <20170204175517.GC8364@lunn.ch> References: <20170203182021.14246-1-vivien.didelot@savoirfairelinux.com> <20170203182021.14246-7-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170203182021.14246-7-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +#define DSA_NOTIFIER_BRIDGE_JOIN 1 > +#define DSA_NOTIFIER_BRIDGE_LEAVE 2 Hi Vivien Is one notifier per event sufficient? I've not looked at what actually needs to happen when a port joins a bridge, in a D in DSA setup. Do we need to both enable the flow of frames around the switch fabric, but also block those frames going out ports they should not? Do we need a first notifier to put in place the blocks, and then a second notifier to enable the flow of packets? What we don't want is a window of time during the fabric setup as a whole is inconsistent, and frames a leaking out ports they should not. Andrew