From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752969AbdBFCzE (ORCPT <rfc822;w@1wt.eu>);
        Sun, 5 Feb 2017 21:55:04 -0500
Received: from vps0.lunn.ch ([178.209.37.122]:56364 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751907AbdBFCzD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 5 Feb 2017 21:55:03 -0500
Date: Mon, 6 Feb 2017 03:54:35 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Eddie Cai <eddie.cai.linux@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, heiko@sntech.de,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux@armlinux.org.uk, linux-rockchip@lists.infradead.org,
        eddie.cai@rock-chips.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker
 board
Message-ID: <20170206025435.GA32506@lunn.ch>
References: <1486347287-31051-1-git-send-email-eddie.cai@rock-chips.com>
 <1486347287-31051-3-git-send-email-eddie.cai@rock-chips.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1486347287-31051-3-git-send-email-eddie.cai@rock-chips.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Eddie

> +		button@0 {
> +			gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
> +			linux,code = <116>;

It is a good idea to use include/dt-bindings/input/input.h

and then you can replace <116> with < KEY_POWER > which is more
readable.

> +			label = "GPIO Key Power";
> +			linux,input-type = <1>;

< EV_KEY >

> +			gpio-key,wakeup = <1>;

This has been replace with wakeup-source.

> +			debounce-interval = <100>;
> +		};
> +	};

  Andrew