Re: [PATCH 3.10 199/319] IB/srpt: Simplify srpt_handle_tsk_mgmt()

Willy Tarreau
2017-02-06T06:33:02Z

Hi Bart,

On Mon, Feb 06, 2017 at 05:14:04AM +0000, Bart Van Assche wrote:
> On Sun, 2017-02-05 at 20:20 +0100, Willy Tarreau wrote:
> > From: Bart Van Assche <bart.vanassche@sandisk.com>
> >
> > commit 51093254bf879bc9ce96590400a87897c7498463 upstream.
> >
> > Let the target core check task existence instead of the SRP target
> > driver. Additionally, let the target core check the validity of the
> > task management request instead of the ib_srpt driver.
> >
> > This patch fixes the following kernel crash:
> >
> > BUG: unable to handle kernel NULL pointer dereference at 0000000000000001
> > IP: [<ffffffffa0565f37>] srpt_handle_new_iu+0x6d7/0x790 [ib_srpt]
> > Oops: 0002 [#1] SMP
> > Call Trace:
> > [<ffffffffa05660ce>] srpt_process_completion+0xde/0x570 [ib_srpt]
> > [<ffffffffa056669f>] srpt_compl_thread+0x13f/0x160 [ib_srpt]
> > [<ffffffff8109726f>] kthread+0xcf/0xe0
> > [<ffffffff81613cfc>] ret_from_fork+0x7c/0xb0
>
> Hi Willy,
>
> The first part of the description of this patch is correct (the part about
> the refactoring) but the second part not (about the kernel crash). If you
> are looking only for patches that fix bugs you may want to skip this patch.

OK I'm dropping it then.

Thanks!
Willy