Re: [PATCH 3.10 275/319] ipc: remove use of seq_printf return value

Willy Tarreau
2017-02-05T20:36:15Z

Hi Joe,

On Sun, Feb 05, 2017 at 11:49:33AM -0800, Joe Perches wrote:
> On Sun, 2017-02-05 at 20:21 +0100, Willy Tarreau wrote:
> > From: Joe Perches <joe@perches.com>
> >
> > commit 7f032d6ef6154868a2a5d5f6b2c3f8587292196c upstream.
> >
> > The seq_printf return value, because it's frequently misused,
> > will eventually be converted to void.
>
> Is this necessary? It doesn't seem so.
>
> This one seems an unlikely candidate to backport as
> it effectively doesn't do anything but prepare for
> seq_printf return value removal.
>
> Is that removal going to be backported too or is this
> being patched to avoid some other backported patch's
> desire to be applied without offsets?

Hmmm sorry, I missed the comment on this one, it was picked
because it makes it easier to apply "ipc/sem.c: fix
complex_count vs. simple op race". This latter was picked
as-is from Jiri's 3.12 tree so I preferred to avoid modifying
it. I'll just mention it in the commit message.

Thanks for notifying me.

Willy