From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751880AbdBFLou (ORCPT ); Mon, 6 Feb 2017 06:44:50 -0500 Received: from mail.us.es ([193.147.175.20]:45716 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbdBFLot (ORCPT ); Mon, 6 Feb 2017 06:44:49 -0500 Date: Mon, 6 Feb 2017 12:44:43 +0100 From: Pablo Neira Ayuso To: Kevin Cernekee Cc: dianders@chromium.org, davem@davemloft.net, netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 2/2] netfilter: ctnetlink: Fix regression in CTA_HELP processing Message-ID: <20170206114443.GB15498@salvia> References: <20170126224944.29047-1-cernekee@chromium.org> <20170126224944.29047-2-cernekee@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170126224944.29047-2-cernekee@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 26, 2017 at 02:49:44PM -0800, Kevin Cernekee wrote: > Prior to Linux 4.4, it was usually harmless to send a CTA_HELP attribute > containing the name of the current helper. That is no longer the case: > as of Linux 4.4, if ctnetlink_change_helper() returns an error from > the ct->master check, processing of the request will fail, skipping the > NFQA_EXP attribute (if present). > > This patch changes the behavior to improve compatibility with user > programs that expect the kernel interface to work the way it did prior > to Linux 4.4. If a user program specifies CTA_HELP but the argument > matches the current conntrack helper name, ignore it instead of generating > an error. Also applied, thanks Kevin.