From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751684AbdBFLs0 (ORCPT ); Mon, 6 Feb 2017 06:48:26 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:33270 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163AbdBFLsY (ORCPT ); Mon, 6 Feb 2017 06:48:24 -0500 Date: Mon, 6 Feb 2017 09:48:18 -0200 From: Gustavo Padovan To: Colin King Cc: Eric Anholt , David Airlie , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vc4: simplify exit path of a failed allocation of dsi_connector Message-ID: <20170206114818.GA28952@joana> Mail-Followup-To: Gustavo Padovan , Colin King , Eric Anholt , David Airlie , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170203195624.7189-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170203195624.7189-1-colin.king@canonical.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Colin, 2017-02-03 Colin King : > From: Colin Ian King > > If dsi_connector fails to allocate, the exit path via label 'fail' > checks if connector is null, which it always is, so the cleanup > that destroys connector is never going to be called. Hence the > failure path can be more optimally performed by removing this > and just returning ERR_PTR(-ENOMEM). This also removes the need > to initialize connector to NULL, and we can also remove ret too. > > Detected by CoverityScan, CID#1399504 ("Logicall Dead Code") > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/vc4/vc4_dsi.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) Reviewed-by: Gustavo Padovan Gustavo