* [PATCH] iommu: fix static checker warning in iommu_insert_device_resv_regions
@ 2017-02-06 9:11 Eric Auger
2017-02-06 13:08 ` Joerg Roedel
0 siblings, 1 reply; 2+ messages in thread
From: Eric Auger @ 2017-02-06 9:11 UTC (permalink / raw)
To: eric.auger.pro, eric.auger, joro, iommu, dan.carpenter,
linux-kernel
In case the device reserved region list is void, the returned value
of iommu_insert_device_resv_regions is uninitialized. Let's return 0
in that case.
This fixes commit 6c65fb318e8b ("iommu: iommu_get_group_resv_regions").
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
Applies on top of iommu-next
---
drivers/iommu/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index b752c3d..f5c9279 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -205,7 +205,7 @@ iommu_insert_device_resv_regions(struct list_head *dev_resv_regions,
struct list_head *group_resv_regions)
{
struct iommu_resv_region *entry;
- int ret;
+ int ret = 0;
list_for_each_entry(entry, dev_resv_regions, list) {
ret = iommu_insert_resv_region(entry, group_resv_regions);
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iommu: fix static checker warning in iommu_insert_device_resv_regions
2017-02-06 9:11 [PATCH] iommu: fix static checker warning in iommu_insert_device_resv_regions Eric Auger
@ 2017-02-06 13:08 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2017-02-06 13:08 UTC (permalink / raw)
To: Eric Auger; +Cc: eric.auger.pro, iommu, dan.carpenter, linux-kernel
On Mon, Feb 06, 2017 at 10:11:38AM +0100, Eric Auger wrote:
> In case the device reserved region list is void, the returned value
> of iommu_insert_device_resv_regions is uninitialized. Let's return 0
> in that case.
>
> This fixes commit 6c65fb318e8b ("iommu: iommu_get_group_resv_regions").
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-06 13:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-06 9:11 [PATCH] iommu: fix static checker warning in iommu_insert_device_resv_regions Eric Auger
2017-02-06 13:08 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox