From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: gregkh@linuxfoundation.org, linux-rdma@vger.kernel.org,
dennis.dalessandro@intel.com, linux-kernel@vger.kernel.org,
grant.likely@secretlab.ca, dledford@redhat.com,
ira.weiny@intel.com
Subject: Re: [PATCH RFC 2/2] IB/hfi1: Fix port ordering issue in a multiport device
Date: Mon, 6 Feb 2017 12:26:42 -0700 [thread overview]
Message-ID: <20170206192642.GA22482@obsidianresearch.com> (raw)
In-Reply-To: <148640853387.13713.5705865367460168894.stgit@tstruk-mobl1.ra.intel.com>
On Mon, Feb 06, 2017 at 11:15:33AM -0800, Tadeusz Struk wrote:
> Some hardware has multiple HFIs within the same ASIC, each one on a
> sepatate bus number. In some devices the numbers labeled on the
> faceplate of the device don't match the PCI bus order, and the result
> is that the devices (ports) are probed in the opposite order of their
> port numbers. The result is IB device unit numbers are in reverse order
> from the faceplate numbering. This leads to confusion, and errors.
> Use EPROBE_DEFER error code to enforce correct port order.
>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
> drivers/infiniband/hw/hfi1/chip.c | 95 ++++++++++++++++++++++++++++++++++++-
> drivers/infiniband/hw/hfi1/chip.h | 2 -
> drivers/infiniband/hw/hfi1/init.c | 1
> 3 files changed, 94 insertions(+), 4 deletions(-)
Still no on this from me, this is a horrible abuse of the device core.
Jason
next prev parent reply other threads:[~2017-02-06 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 19:15 [PATCH RFC 1/2] driver core: allow EPROBE_DEFER after boot Tadeusz Struk
2017-02-06 19:15 ` [PATCH RFC 2/2] IB/hfi1: Fix port ordering issue in a multiport device Tadeusz Struk
2017-02-06 19:26 ` Jason Gunthorpe [this message]
2017-02-06 21:04 ` Christoph Hellwig
2017-02-07 9:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206192642.GA22482@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox