From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752219AbdBFT0s (ORCPT ); Mon, 6 Feb 2017 14:26:48 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:57950 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751471AbdBFT0r (ORCPT ); Mon, 6 Feb 2017 14:26:47 -0500 Date: Mon, 6 Feb 2017 12:26:42 -0700 From: Jason Gunthorpe To: Tadeusz Struk Cc: gregkh@linuxfoundation.org, linux-rdma@vger.kernel.org, dennis.dalessandro@intel.com, linux-kernel@vger.kernel.org, grant.likely@secretlab.ca, dledford@redhat.com, ira.weiny@intel.com Subject: Re: [PATCH RFC 2/2] IB/hfi1: Fix port ordering issue in a multiport device Message-ID: <20170206192642.GA22482@obsidianresearch.com> References: <148640852878.13713.11121939459524566022.stgit@tstruk-mobl1.ra.intel.com> <148640853387.13713.5705865367460168894.stgit@tstruk-mobl1.ra.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <148640853387.13713.5705865367460168894.stgit@tstruk-mobl1.ra.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 06, 2017 at 11:15:33AM -0800, Tadeusz Struk wrote: > Some hardware has multiple HFIs within the same ASIC, each one on a > sepatate bus number. In some devices the numbers labeled on the > faceplate of the device don't match the PCI bus order, and the result > is that the devices (ports) are probed in the opposite order of their > port numbers. The result is IB device unit numbers are in reverse order > from the faceplate numbering. This leads to confusion, and errors. > Use EPROBE_DEFER error code to enforce correct port order. > > Reviewed-by: Ira Weiny > Signed-off-by: Tadeusz Struk > drivers/infiniband/hw/hfi1/chip.c | 95 ++++++++++++++++++++++++++++++++++++- > drivers/infiniband/hw/hfi1/chip.h | 2 - > drivers/infiniband/hw/hfi1/init.c | 1 > 3 files changed, 94 insertions(+), 4 deletions(-) Still no on this from me, this is a horrible abuse of the device core. Jason