From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752615AbdBGAGv (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Feb 2017 19:06:51 -0500
Received: from zeniv.linux.org.uk ([195.92.253.2]:43302 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752407AbdBGAGu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Feb 2017 19:06:50 -0500
Date: Tue, 7 Feb 2017 00:06:42 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] namei: Remove unlikely annotation for revalidate check
 in lookup_fast()
Message-ID: <20170207000642.GH13195@ZenIV.linux.org.uk>
References: <20170206171735.17d2a5c8@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170206171735.17d2a5c8@gandalf.local.home>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 06, 2017 at 05:17:35PM -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> 
> The likely/unlikely profiler showed that the unlikely around the
> dentry->d_flags & DCACHE_OP_REVALIDATE was wrong 95% of the time. Adding
> trace_printk()s, it revealed that the dentry ops had hooks to:
> 
>  kernfs_dop_revalidate
>  pid_revalidate
>  proc_sys_revalidate
>  tid_fd_revalidate
> 
> As tools today now access files that have these operations often, it's best
> just to remove the annotation, as it is more dependent on use cases and not
> normal mode of operation if it will be true or not.

"Tools" being what, exactly?  What kind of load had that been measured on?