Re: [PATCH 1/2] kconfig/mconf: add jumping tip in title of search result textbox

["Du, Changbin" <changbin.du@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]

On Mon, Feb 06, 2017 at 02:00:51PM +0200, Jani Nikula wrote:
> On Mon, 06 Feb 2017, changbin.du@intel.com wrote:
> > From: Changbin Du <changbin.du@intel.com>
> >
> > Prompt user how to quickly jump to the item he/she is interested in.
> 
> :o
> 
> All these years. I... I didn't know. Thanks!
>
aha, me too! You know, back to the top menu then look into step by
step...

> > Signed-off-by: Changbin Du <changbin.du@intel.com>
> > ---
> >  scripts/kconfig/mconf.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> > index 315ce2c..23d5681 100644
> > --- a/scripts/kconfig/mconf.c
> > +++ b/scripts/kconfig/mconf.c
> > @@ -443,10 +443,10 @@ static void search_conf(void)
> >  
> >  		res = get_relations_str(sym_arr, &head);
> >  		set_subtitle();
> > -		dres = show_textbox_ext(_("Search Results"), (char *)
> > -					str_get(&res), 0, 0, keys, &vscroll,
> > -					&hscroll, &update_text, (void *)
> > -					&data);
> > +		dres = show_textbox_ext(
> > +				_("Search Results (type the number to jump)"),
> > +				(char *)str_get(&res), 0, 0, keys, &vscroll,
> > +				&hscroll, &update_text, (void *)&data);
> 
> It would be even better and discoverable if this could be turned into a
> dialog menu, so that you could navigate the search results using arrow
> keys and hit enter to choose. But this is already an improvement.
> 
Yes, that will have a better experience. :)

> >  		again = false;
> >  		for (i = 0; i < JUMP_NB && keys[i]; i++)
> >  			if (dres == keys[i]) {
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center

-- 
Thanks,
Changbin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]