Re: [PATCH 78/89] sched/core: Remove the tsk_cpus_allowed() wrapper

Ingo Molnar
2017-02-06T22:03:13Z

* Peter Zijlstra <peterz@infradead.org> wrote:

> > +++ b/arch/powerpc/kernel/smp.c
> > +++ b/arch/sparc/kernel/sysfs.c
> > +++ b/drivers/cpufreq/sparc-us2e-cpufreq.c
> > +++ b/drivers/cpufreq/sparc-us3-cpufreq.c

> > - cpumask_copy(&cpus_allowed, tsk_cpus_allowed(current));
> > + cpumask_copy(&cpus_allowed, &current->cpus_allowed);
>
> Note that all those, and this is where I stopped looking, appear broken vs
> userspace changing the mask right after.

But these are pre-existing bugs in code twidding ->cpus_allowed, not caused by my
patch, right?

I.e. my changes made you notice pre-existing bugs.

Thanks,

Ingo