From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753167AbdBGIG5 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Feb 2017 03:06:57 -0500
Received: from merlin.infradead.org ([205.233.59.134]:37110 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751164AbdBGIG4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Feb 2017 03:06:56 -0500
Date: Tue, 7 Feb 2017 09:06:47 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Mike Galbraith <efault@gmx.de>, Oleg Nesterov <oleg@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 78/89] sched/core: Remove the tsk_cpus_allowed() wrapper
Message-ID: <20170207080647.GS6500@twins.programming.kicks-ass.net>
References: <1486387772-18837-1-git-send-email-mingo@kernel.org>
 <1486387772-18837-79-git-send-email-mingo@kernel.org>
 <20170206145908.GO6515@twins.programming.kicks-ass.net>
 <20170206220308.GA7481@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170206220308.GA7481@gmail.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 06, 2017 at 11:03:08PM +0100, Ingo Molnar wrote:
> 
> * Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > > +++ b/arch/powerpc/kernel/smp.c
> > > +++ b/arch/sparc/kernel/sysfs.c
> > > +++ b/drivers/cpufreq/sparc-us2e-cpufreq.c
> > > +++ b/drivers/cpufreq/sparc-us3-cpufreq.c
> 
> > > -	cpumask_copy(&cpus_allowed, tsk_cpus_allowed(current));
> > > +	cpumask_copy(&cpus_allowed, &current->cpus_allowed);
> > 
> > Note that all those, and this is where I stopped looking, appear broken vs 
> > userspace changing the mask right after.
> 
> But these are pre-existing bugs in code twidding ->cpus_allowed, not caused by my 
> patch, right?

Yes..

> I.e. my changes made you notice pre-existing bugs.

I think I spotted them when I made the tsk_cpus_allowed() thing as well.
Just wanted to call them out again.