From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753378AbdBGIgP (ORCPT ); Tue, 7 Feb 2017 03:36:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35062 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753298AbdBGIgL (ORCPT ); Tue, 7 Feb 2017 03:36:11 -0500 Date: Tue, 7 Feb 2017 09:35:57 +0100 From: Benjamin Tissoires To: Bastien Nocera Cc: Jiri Kosina , Peter Hutterer , Nestor Lopez Casado , Olivier Gay , Simon Wood , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in power_supply Message-ID: <20170207083557.GD16529@mail.corp.redhat.com> References: <20170202141229.17322-1-benjamin.tissoires@redhat.com> <20170202141229.17322-6-benjamin.tissoires@redhat.com> <1486134491.2316.11.camel@hadess.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1486134491.2316.11.camel@hadess.net> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 07 Feb 2017 08:36:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bastien, On Feb 03 2017 or thereabouts, Bastien Nocera wrote: > On Thu, 2017-02-02 at 15:12 +0100, Benjamin Tissoires wrote: > > +               case POWER_SUPPLY_PROP_MANUFACTURER: > > +                       val->strval = "Logitech, Inc."; > > I don't like this change. I'd prefer the concatenated manufacturer and > model strings leading to user-friendly strings, and "Logitech T650" is > better than "Logitech, Inc. T650". Is this the only problematic issue? We are at rc7 already so I would like to have the final version ready ASAP. Cheers, Benjamin