Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in power_supply

Bastien Nocera
2017-03-06T12:30:25Z

On Mon, 2017-03-06 at 13:18 +0100, Jiri Kosina wrote:
> On Tue, 7 Feb 2017, Benjamin Tissoires wrote:
>
> > > > +               case POWER_SUPPLY_PROP_MANUFACTURER:
> > > > +                       val->strval = "Logitech, Inc.";
> > >
> > > I don't like this change. I'd prefer the concatenated
> > > manufacturer and
> > > model strings leading to user-friendly strings, and "Logitech
> > > T650" is
> > > better than "Logitech, Inc. T650".
> >
> > Is this the only problematic issue? We are at rc7 already so I
> > would
> > like to have the final version ready ASAP.
>
> Bastien, do you have any input on the rest of the series please?

My comment about "[PATCH 04/15] HID: logitech-hidpp: battery: remove
overloads and provide ONLINE" is the blocker.

No particular comments about the rest of the series.