From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752983AbdBGJN7 (ORCPT ); Tue, 7 Feb 2017 04:13:59 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45630 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751567AbdBGJN4 (ORCPT ); Tue, 7 Feb 2017 04:13:56 -0500 Date: Tue, 7 Feb 2017 10:13:56 +0100 From: Greg KH To: Christoph Hellwig , Jason Gunthorpe , Tadeusz Struk , linux-rdma@vger.kernel.org, dennis.dalessandro@intel.com, linux-kernel@vger.kernel.org, grant.likely@secretlab.ca, dledford@redhat.com, ira.weiny@intel.com Subject: Re: [PATCH RFC 2/2] IB/hfi1: Fix port ordering issue in a multiport device Message-ID: <20170207091356.GA28400@kroah.com> References: <148640852878.13713.11121939459524566022.stgit@tstruk-mobl1.ra.intel.com> <148640853387.13713.5705865367460168894.stgit@tstruk-mobl1.ra.intel.com> <20170206192642.GA22482@obsidianresearch.com> <20170206210425.GA2062@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170206210425.GA2062@infradead.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 06, 2017 at 01:04:25PM -0800, Christoph Hellwig wrote: > On Mon, Feb 06, 2017 at 12:26:42PM -0700, Jason Gunthorpe wrote: > > Still no on this from me, this is a horrible abuse of the device core. > > Seconded. Netdevice (and thus RDMA) devices names generated by the > kernel are not stable, period. Use udev and the MAC / port GUID or > whatever the OFI equivalent is to generate stable device names. Thirded :)