From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754175AbdBGMTP (ORCPT ); Tue, 7 Feb 2017 07:19:15 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35452 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753937AbdBGMTM (ORCPT ); Tue, 7 Feb 2017 07:19:12 -0500 Date: Tue, 7 Feb 2017 13:19:09 +0100 From: Thierry Reding To: Mark Yao Cc: David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/7] drm/rockchip: gem: add mutex lock for drm mm Message-ID: <20170207121909.GA18315@ulmo.ba.sec> References: <1486456542-18675-1-git-send-email-mark.yao@rock-chips.com> <1486456542-18675-4-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jRHKVT23PllUwdXP" Content-Disposition: inline In-Reply-To: <1486456542-18675-4-git-send-email-mark.yao@rock-chips.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jRHKVT23PllUwdXP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 07, 2017 at 04:35:38PM +0800, Mark Yao wrote: > drm_mm_insert_node_generic and drm_mm_remove_node may access same > resource with list ops, it's not threads safe, so protect this context > with mutex lock. >=20 > Fix bug: > [49451.856244] =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > [49451.856350] BUG: KASAN: wild-memory-access on address dead000000000108 > [49451.856379] Write of size 8 by task Binder:218_4/683 > [49451.856417] CPU: 2 PID: 683 Comm: Binder:218_4 Not tainted 4.4.36 #62 > [49451.856443] Hardware name: Rockchip RK3399 Excavator Board edp (Androi= d) (DT) > [49451.856469] Call trace: > [49451.856519] [] dump_backtrace+0x0/0x230 > [49451.856556] [] show_stack+0x14/0x1c > [49451.856592] [] dump_stack+0xa0/0xc8 > [49451.856633] [] kasan_report+0x110/0x4dc > [49451.856670] [] __asan_store8+0x24/0x7c > [49451.856715] [] drm_mm_insert_node_generic+0x2dc/0x464 > [49451.856760] [] rockchip_gem_iommu_map+0x60/0x158 > [49451.856794] [] rockchip_gem_create_object+0x278/0x488 > [49451.856827] [] rockchip_gem_create_with_handle+0x24/= 0x10c > [49451.856862] [] rockchip_gem_create_ioctl+0x3c/0x50 > [49451.856896] [] drm_ioctl+0x354/0x52c > [49451.856939] [] do_vfs_ioctl+0x670/0x78c > [49451.856976] [] SyS_ioctl+0x60/0x88 > [49451.857009] [] el0_svc_naked+0x24/0x28 >=20 > Change-Id: I2ea377aa9ca24f70c59e2d86f2a6ad5ccb9c0891 This is meaningless in an upstream tree. Please remove. Thierry --jRHKVT23PllUwdXP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAliZuzoACgkQ3SOs138+ s6FH3A/6AwgZdl4NnAX/xBmWmzAiHXyJW/ATNJm2yBvmgaaM5JjssQAeg8nJ00LB WGQOroSDrgHuPRonXQX9WQY2z4eSquPIj9qLhF+EB7CzgUQ7S4dSvn8sHxyTxT74 b1S4vT1gC2mSj3XONXN4MZBEolr5AYHshxDJsKHnPQuan3LNkLBK97vycH2CtCna aB4XdUQWCbC0qxxvmnOuZh34yf8BUfebdkQqEnD8QlB6SFuZmK3+Zq23ZciKRgme qG28kWSKq14rySL+RnPsTitAKLSfVwGw22CA6CaSEHa0ieR6MpjTMdEKt9zz2Ejb HpNf+3iLdyMEgDwftat6ys1HXD1qQX6BHQN1N7tXLZ49Wz1nfqcDZJIwANFR94j+ ocSFuPutMDwQ9cwmQe61awjr86OQuA8Mdso6faIx6AQTgUhs2ZmtYH2p4F35u6x9 ZmbIeGmWttqbiiXoUYuCXtgecAhgN7y3lUZPX+6gwO+jYyfXMriV+hCDv++9v230 WBi396AEp4PToZUfO2L9iz3Lp+wjakMjGpqjfsz7VZ9GkKkHJBjlzztxyDUZzyBq A9jWogXMl6qS7ZYyZd9a06gEAeunz9ttbg9pULZCQi94VqZWuQxE6buF2BsXyj9e dTnzyNI5Y2sWHX1ZYkmc70gQwIBZHhB6JPgsRfuVf36lRStAc+A= =1y6h -----END PGP SIGNATURE----- --jRHKVT23PllUwdXP--