From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754199AbdBGMhN (ORCPT ); Tue, 7 Feb 2017 07:37:13 -0500 Received: from mail-wj0-f194.google.com ([209.85.210.194]:35732 "EHLO mail-wj0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753522AbdBGMhL (ORCPT ); Tue, 7 Feb 2017 07:37:11 -0500 Date: Tue, 7 Feb 2017 13:37:07 +0100 From: Thierry Reding To: Mark Yao Cc: David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Tomasz Figa Subject: Re: [PATCH v2 7/7] drm/rockchip: Call drm_gem_object_release() to destroy GEM base Message-ID: <20170207123707.GC18315@ulmo.ba.sec> References: <1486456542-18675-1-git-send-email-mark.yao@rock-chips.com> <1486456773-19233-1-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wxDdMuZNg1r63Hyj" Content-Disposition: inline In-Reply-To: <1486456773-19233-1-git-send-email-mark.yao@rock-chips.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wxDdMuZNg1r63Hyj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 07, 2017 at 04:39:33PM +0800, Mark Yao wrote: > From: Tomasz Figa >=20 > When converting the driver to use shmem-backed GEMs for IOMMU-enabled > systems, we forgot to add calls to drm_gem_object_release(), which gave > us a quite nice memory leak. This patch adds the missing calls. >=20 > Fixes: f11d5f0 ("FROMLIST: drm/rockchip: Do not use DMA mapping API if > attached to IOMMU domain") >=20 > TEST=3Dwhile true; do backlight_dbus_tool --set --percent=3D0 && sleep 8 = && > backlight_dbus_tool --set --percent=3D100 && sleep 3 ; done Ugh... please clean up your commit messages before posting to the mailing list. FROMLIST: patches clearly aren't what will be merged upstream and the SHA1 isn't going to match, so nobody but you will find this anywhere. > Signed-off-by: Tomasz Figa > Signed-off-by: Mark Yao > Reviewed-on: https://chromium-review.googlesource.com/385456 This is also present in some of the patches you posted, but it's not typical for these to be included in upstream patches because usually by the time patches from some gerrit make it to upstream, upstream can have diverged significantly enough for the review to no longer apply. Thierry --wxDdMuZNg1r63Hyj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAliZv3MACgkQ3SOs138+ s6GzjhAAv7tPGsyxdRyHhnZ05Fcr2woFS8dAkIot5TQCUwd+/DZQV4R3pdGZu0OI nYPXyJ6YwlhesuUxVl6p1BWWphLE3Bo0FRHMihsE4mG5otLd4ldP+8e5YJ+VXgk5 nKAVc5JatZPJOu0ZMBqZbeIJY/Hoe0dc3m429BszAUZbYJfSjDVE2/IUkbbVovMf 8XVyW8MLCAwcd27mAqrioc8JTQ3xVrZYph2v3Mr7zHaJn1+PDq5JaecxVymNQbhC LC5kQJGj8Jvk1H2Y2Zf8U4fJvQtj3t3y/a2tDRzoVswIlrApVPekFjCN0y044znk DYo+xJggO6laEVGvi4bwc0m2nImIjXWn/wamQyhPCYJCIJKI5mXr4TMHkdL7DHOB o6TQUQACWEIm7n/DJnTeHiZl0Q0X66Q8G8CdAUTdqjVisDjbVpApGVEyNH2ViT7S 5GdMu0nHRpTu6z4hkrYz4Swh4m5jLTFlkAE9+Q7Zl3yuW+16zpdzrEbSFkKojZ6/ X71KpA6ewwCXNzlfrxBP45gcPj/3qln7/sfKJP4X0hd4coTpALJmsKqtmwGbblEJ D9Y5R6oV2tnspkdvdTv0aBqCQ9OhKIDU5xrer7CeJKJ0mCNbgYqLaYboQ2pprIS8 gbRQRhtV3gaibzLROLV+MfkK5m3knDw7a8dR1E5AJ7tXwoxKLZY= =qwRi -----END PGP SIGNATURE----- --wxDdMuZNg1r63Hyj--