From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755238AbdBGQG7 (ORCPT ); Tue, 7 Feb 2017 11:06:59 -0500 Received: from mail-yw0-f173.google.com ([209.85.161.173]:33032 "EHLO mail-yw0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754972AbdBGQF5 (ORCPT ); Tue, 7 Feb 2017 11:05:57 -0500 Date: Tue, 7 Feb 2017 11:05:54 -0500 From: Sean Paul To: Mark Yao Cc: David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/rockchip: cdn-dp: fix cdn-dp complie warning Message-ID: <20170207160554.GF15150@art_vandelay> References: <1486431241-11374-1-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486431241-11374-1-git-send-email-mark.yao@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 07, 2017 at 09:34:01AM +0800, Mark Yao wrote: > fix warning: > > drivers/gpu/drm/rockchip/cdn-dp-reg.c:632:24: warning: > 'val[1]' may be used uninitialized in this function [-Wmaybe-uninitialized] > msa_misc = 2 * val[0] + 32 * val[1] + > > Signed-off-by: Mark Yao > --- > drivers/gpu/drm/rockchip/cdn-dp-reg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-reg.c b/drivers/gpu/drm/rockchip/cdn-dp-reg.c > index 3a5b8a4..319dbba 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-reg.c > +++ b/drivers/gpu/drm/rockchip/cdn-dp-reg.c > @@ -592,7 +592,7 @@ static int cdn_dp_get_msa_misc(struct video_info *video, > struct drm_display_mode *mode) > { > u32 msa_misc; > - u8 val[2]; > + u8 val[2] = {0}; Kind of a nit, but it would be better to add default cases to the switches below so it's more obvious which format/depth you consider the fallback. Sean > > switch (video->color_fmt) { > case PXL_RGB: > -- > 1.9.1 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS