From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754072AbdBGUxV (ORCPT ); Tue, 7 Feb 2017 15:53:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44526 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755321AbdBGUxS (ORCPT ); Tue, 7 Feb 2017 15:53:18 -0500 Date: Tue, 7 Feb 2017 21:52:49 +0100 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] kvm: vmx: Use the hardware provided GPA instead of page walk Message-ID: <20170207205248.GE31091@potion> References: <1485542088-18610-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1485542088-18610-1-git-send-email-pbonzini@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 07 Feb 2017 20:52:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-01-27 19:34+0100, Paolo Bonzini: > As in the SVM patch, the guest physical address is passed by > VMX to x86_emulate_instruction already, so mark the GPA as available > in vcpu->arch. > > Signed-off-by: Paolo Bonzini > --- In line with the SVM patch, Reviewed-by: Radim Krčmář Still, I don't see why we need a variable that is touched on every VM exit. Is this a mere shortcut to propagating the gpa_available bit with the gpa argument to kvm_mmu_page_fault() and x86_emulate_instruction()? Thanks.