Re: [PATCH] kvm: vmx: Use the hardware provided GPA instead of page walk

Paolo Bonzini
2017-02-08T08:16:15Z

On 07/02/2017 21:52, Radim Krčmář wrote:
> 2017-01-27 19:34+0100, Paolo Bonzini:
>> As in the SVM patch, the guest physical address is passed by
>> VMX to x86_emulate_instruction already, so mark the GPA as available
>> in vcpu->arch.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>
> In line with the SVM patch,
>
> Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
>
> Still, I don't see why we need a variable that is touched on every VM
> exit. Is this a mere shortcut to propagating the gpa_available bit with
> the gpa argument to kvm_mmu_page_fault() and x86_emulate_instruction()?

Yes, pretty much.

Paolo