From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932850AbdBHA7B (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Feb 2017 19:59:01 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:42165 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932269AbdBHA6t (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Feb 2017 19:58:49 -0500
Date: Wed, 8 Feb 2017 03:58:06 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Carlos Palminha <CARLOS.PALMINHA@synopsys.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org
Subject: Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings
Message-ID: <20170208005806.GF11154@mwanda>
References: <20170208004722.26305-1-palminha@synopsys.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170208004722.26305-1-palminha@synopsys.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 08, 2017 at 12:47:22AM +0000, Carlos Palminha wrote:
> Fixed the following sparse warnings:
> * cast from restricted __le32
> * invalid assignment from int to __le32
> 

The changelog doesn't give me any confidence that you understand the
implications of this patch.  You silenced the warning but I think you
may be introducing bugs (I haven't done a thourough review).

regards,
dan carpenter