From: Dan Carpenter <dan.carpenter@oracle.com>
To: Carlos Palminha <CARLOS.PALMINHA@synopsys.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings
Date: Wed, 8 Feb 2017 09:09:00 +0300 [thread overview]
Message-ID: <20170208060859.GG11154@mwanda> (raw)
In-Reply-To: <1abdb4fa-9161-2891-ded6-83763d678c2e@synopsys.com>
On Wed, Feb 08, 2017 at 01:19:39AM +0000, Carlos Palminha wrote:
>
>
> On 08-02-2017 00:58, Dan Carpenter wrote:
> >On Wed, Feb 08, 2017 at 12:47:22AM +0000, Carlos Palminha wrote:
> >>Fixed the following sparse warnings:
> >>* cast from restricted __le32
> >>* invalid assignment from int to __le32
> >>
> >
> >The changelog doesn't give me any confidence that you understand the
> >implications of this patch. You silenced the warning but I think you
> >may be introducing bugs (I haven't done a thourough review).
> >
> >regards,
> >dan carpenter
> >
> true... i was short on words.
> will resend v2 with better description.
I'm pretty sure the original code is correct and just the sparse
annotations are wrong.
regards,
dan carpenter
prev parent reply other threads:[~2017-02-08 6:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 0:47 [PATCH] staging: rtl8712: rtl8712: fix sparse warnings Carlos Palminha
2017-02-08 0:58 ` Dan Carpenter
2017-02-08 1:19 ` Carlos Palminha
2017-02-08 6:09 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208060859.GG11154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox