From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753613AbdBHGKq (ORCPT ); Wed, 8 Feb 2017 01:10:46 -0500 Received: from aserp1050.oracle.com ([141.146.126.70]:37001 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbdBHGKo (ORCPT ); Wed, 8 Feb 2017 01:10:44 -0500 Date: Wed, 8 Feb 2017 09:09:00 +0300 From: Dan Carpenter To: Carlos Palminha Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8712: rtl8712: fix sparse warnings Message-ID: <20170208060859.GG11154@mwanda> References: <20170208004722.26305-1-palminha@synopsys.com> <20170208005806.GF11154@mwanda> <1abdb4fa-9161-2891-ded6-83763d678c2e@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1abdb4fa-9161-2891-ded6-83763d678c2e@synopsys.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserp1040.oracle.com [141.146.126.69] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2017 at 01:19:39AM +0000, Carlos Palminha wrote: > > > On 08-02-2017 00:58, Dan Carpenter wrote: > >On Wed, Feb 08, 2017 at 12:47:22AM +0000, Carlos Palminha wrote: > >>Fixed the following sparse warnings: > >>* cast from restricted __le32 > >>* invalid assignment from int to __le32 > >> > > > >The changelog doesn't give me any confidence that you understand the > >implications of this patch. You silenced the warning but I think you > >may be introducing bugs (I haven't done a thourough review). > > > >regards, > >dan carpenter > > > true... i was short on words. > will resend v2 with better description. I'm pretty sure the original code is correct and just the sparse annotations are wrong. regards, dan carpenter