From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932208AbdBHGlD (ORCPT ); Wed, 8 Feb 2017 01:41:03 -0500 Received: from gateway20.websitewelcome.com ([192.185.62.46]:47642 "EHLO gateway20.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932096AbdBHGlC (ORCPT ); Wed, 8 Feb 2017 01:41:02 -0500 X-Greylist: delayed 1299 seconds by postgrey-1.27 at vger.kernel.org; Wed, 08 Feb 2017 01:41:02 EST Date: Wed, 8 Feb 2017 00:18:50 -0600 From: "Gustavo A. R. Silva" To: gregkh@linuxfoundation.org, paul.gortmaker@windriver.com, yamada.masahiro@socionext.com, akpm@linux-foundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drivers: usb: early: remove unused code Message-ID: <20170208061850.GA6707@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.192.77.148 X-Exim-ID: 1cbLad-000C5u-5d X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [187.192.77.148]:46812 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove this line of code because devnum is overwritten before it can be used. This could happen if line of code 609 (goto try_again;) is executed. Otherwise, devnum is never used again. Addresses-Coverity-ID: 1226870 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/early/ehci-dbgp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/early/ehci-dbgp.c b/drivers/usb/early/ehci-dbgp.c index ea73afb..e265444 100644 --- a/drivers/usb/early/ehci-dbgp.c +++ b/drivers/usb/early/ehci-dbgp.c @@ -580,7 +580,6 @@ static int _dbgp_external_startup(void) USB_DEBUG_DEVNUM); goto err; } - devnum = USB_DEBUG_DEVNUM; dbgp_printk("debug device renamed to 127\n"); } -- 2.5.0