From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: gregkh@linuxfoundation.org, balbi@kernel.org, bhumirks@gmail.com,
mina86@mina86.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] drivers: usb: gadget: udc: remove logically dead code
Date: Wed, 8 Feb 2017 01:25:37 -0600 [thread overview]
Message-ID: <20170208072537.GA8700@embeddedgus> (raw)
In-Reply-To: <20170208072212.GA8209@embeddedgus>
Remove unnecesary code because zlt never evaluates to zero.
Addresses-Coverity-ID: 1226747
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/usb/gadget/udc/mv_udc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c
index 56b3574..9ca6d92 100644
--- a/drivers/usb/gadget/udc/mv_udc_core.c
+++ b/drivers/usb/gadget/udc/mv_udc_core.c
@@ -509,7 +509,7 @@ static int mv_ep_enable(struct usb_ep *_ep,
dqh = ep->dqh;
dqh->max_packet_length = (max << EP_QUEUE_HEAD_MAX_PKT_LEN_POS)
| (mult << EP_QUEUE_HEAD_MULT_POS)
- | (zlt ? EP_QUEUE_HEAD_ZLT_SEL : 0)
+ | EP_QUEUE_HEAD_ZLT_SEL
| (ios ? EP_QUEUE_HEAD_IOS : 0);
dqh->next_dtd_ptr = 1;
dqh->size_ioc_int_sts = 0;
--
2.5.0
next prev parent reply other threads:[~2017-02-08 7:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 7:22 [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch Gustavo A. R. Silva
2017-02-08 7:25 ` Gustavo A. R. Silva [this message]
2017-02-08 9:23 ` Felipe Balbi
2017-02-08 10:02 ` Gustavo A. R. Silva
2017-02-08 12:05 ` Felipe Balbi
2017-02-08 13:03 ` Greg KH
2017-02-08 13:13 ` Felipe Balbi
2017-02-08 13:16 ` Michal Nazarewicz
2017-02-08 13:21 ` Greg KH
2017-02-08 14:49 ` [PATCH] usb: gadget: mv_udc: clarify a switch with an implicit fall-through Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208072537.GA8700@embeddedgus \
--to=garsilva@embeddedor.com \
--cc=balbi@kernel.org \
--cc=bhumirks@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox