From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933234AbdBHJmB (ORCPT ); Wed, 8 Feb 2017 04:42:01 -0500 Received: from mail-he1eur01on0072.outbound.protection.outlook.com ([104.47.0.72]:44352 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753856AbdBHJlz (ORCPT ); Wed, 8 Feb 2017 04:41:55 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; Date: Wed, 8 Feb 2017 11:41:47 +0200 From: Ido Schimmel To: Philippe Reynes CC: , , , Subject: Re: [PATCH] net: mellanox: switchx2: use new api ethtool_{get|set}_link_ksettings Message-ID: <20170208094147.GA25073@splinter.mtl.com> References: <1486508853-29623-1-git-send-email-tremyfr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1486508853-29623-1-git-send-email-tremyfr@gmail.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: DB6PR0802CA0044.eurprd08.prod.outlook.com (10.172.252.158) To AM4PR0501MB2833.eurprd05.prod.outlook.com (10.172.216.140) X-MS-Office365-Filtering-Correlation-Id: 43e05a76-1a8e-419c-b473-08d45006b659 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:AM4PR0501MB2833; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2833;3:gygdEmg2PCag8Ot7BYuotZlXhWgIRHOOJG3/GIAcfvkGM/Kk3eS6qVP2G4TjwNeJBgYhW0YHJf6QXAZzuW8W2qe/bYwdM/ceKmM9VBsyOU239qcnSDhpmk/BvkhmXm123hbMfiYPTRnRAWyQlx3qEVOmbFc2HeAjf/Y8HLw0RVuup6s2KC5m5LWPRbtVuBDK4RqLBdc/Ac5mA3ela8psTT20sExR2TuThB14Z/uv6WrZZqmxMovulck+m5ZoN9Nx7DRfVfNjMy86uT9Gwu2JFSyY3R3gNKURyGByUnz18fg=;25:Hu4tIdOFfx2B2yHRlonaF1iQCtiQTf2y710ycrVa2rc1XJPRA0uQhgVVF0ou2QWf2lLirhRsCEwbu6IVB77Y0pihgmN/8rSnAetBs5GFbY1KbusutBeBN/grzi5LQcv3QTpgocEUYglpnhQsONMNPLv0PR8SwtlyKVocNvr90nyzwLQqZ5dh5iBRG4Q0R+wRWkegnSUfPkqundsE9NKvwb3F6zDID2Z1Y4Ucp8Ls9+qxUVbZO4JHy+De9qIgPNqKuzEhqkKXBjyOPWAQAvxEd0OkJK8h2CrNkvMlEbE5W9IT9XfsrTk94pANOLFS0fhJE4xl56DFMftUAWzyU/qb0d1ulpZ9SNbchSJ8vz2PnJYuSZX77Hz0kcRBwDbhQWBqCnl9Eng2TwBG6OvKkLDxsUBMZSxFB/MgNmlhgKdXmk6hSt4FZtpe3C2Vj9f2csfyASqizxO0OAbgYEUsifbEGA== X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2833;31:4040Us83cdfWdycvr8lUpBP64f9FXUi/Fbs08MTp1YrkaCWc1yhkMjatnAi/ZkxyR97M1dI6RRCwAf4E4aQhxdJIsPZIvzDnVHESkfIpvkNfW8KG7rjLlon4rN3EKwjsv72OkwPD9Hom1Bxr+dly51fC53gfMKDCfzscfQkv91EiT4cT1903b/jPR+yNhC7t8EJdoAhisi0FZj67/Lfmh5+Feq91pu9hE3qUdlBkNrVDG123o4RPMwY6Y/ioFh2Q;20:Dgeb6/oJeFe/AEFOQq1m8jOYEHmq9IiQk9M72XvkUGe3X/Ypi5qz3ys6dJeIciz2HPyZujnUF+1FP+yUbPcx/beAdtrgcsmrjmuC5T3YQZO9u08E0P4S0B9mLrVzO3zJvPjQzVMLZrgtq2c4WJqSLgyiPmaaZMmk7k66i9SNDcK0m/KJp4gb9D2tSRt7pZoByS6jCqjrOsfbTwqCHhXJ2XPGYtxH60SPWNUxkJ3nYL2gZNiMFtD5NoI8tY0lFj4p5dm02z1QiE3oaJjxf2NbPJlAgA++85J+XQ+dvA6PGfPvXnlH/VAtoQsbBQKhyJcexZSSn0KgJV2phLqAwddAwWzjXdXowBOuw/qHgCGvtB1j7esJvyLGmhazY34xAaKrtZcSTF9nGHG3NOqCYcEY9kzc1qTlfdmIfHulO54v5j/BwaqkMXKn+9ADA0u3TgktgJl8IrCt3q+0MHqwc2K+3+EHMApnGA+T4iWdBaV+USNC74POy24+E1xImOPqluDI X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(2017020702029)(20170203043)(3002001)(10201501046)(6055026)(6041248)(20161123558025)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(6072148);SRVR:AM4PR0501MB2833;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0501MB2833; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2833;4:Z+ytiNukBO2zlXw1SjSqQyb7LrnuII4K5rHktUZ8Mzuu2fvytC0bdwkFLPrP9sG4sRgOAOtMdCX5/vq2pxZTcc49GSmYjPyQsReCJtbabby4NMskdsh8qwPu/EcSm+thDxfvIplMpIdNg7dLjQeXkkn52j6Yz7szOyn8s9yHAQKemLPd3WzOk8mqg4bJPesCI2hP0ALc4mYUzjtu6IIonWFhGG3NSFAjtsH5HLXNC6BGcBoqaSU0tXK8sBw5QkxsqljqUtXSAipPfx8FKCYtCSyf4A5wtvsWj9gJq/hKviErYgnzo6Hjg94P8JrPBeGlb/NeTOKur3A5O6si1toAeSGnaO8kym+iLrMMz3CNuuclxMa+3TJBrY/iYl8cdCkEkp9bpGYSVUIiE9v+Op2FizMZa69jsNXLqoATgB+OVgXSLFCZ4/ELoaaeCnveY3KGviF5ENJ2mrCzbpXmk2gnA09nMIjAranzb8pN1FWab/vFze1I07l3rhGpadZVgcmxABTQvKt4OL0aB6qMo7OgZm3y/x3XH6ikRm4Vq3F2tQgRqTR8koPwmAth4bS1PbxlYi/B9LUx85LSrjWJx2R93oKk15O8h1isDuNNSoSr5eiyJJFleR2+jL9az4CcO0ExF9f51BB6RMPP4bsn46Ed1ji7pGglbOibpZYz5uQwQDTfwETMSu94w8kTYrj6GZ2L X-Forefront-PRVS: 0212BDE3BE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(39860400002)(39840400002)(39850400002)(39410400002)(39450400003)(189002)(24454002)(199003)(76506005)(105586002)(6116002)(2906002)(42186005)(23726003)(1076002)(305945005)(3846002)(38730400002)(4326007)(6666003)(6916009)(2950100002)(97756001)(110136004)(39060400001)(9686003)(54906002)(25786008)(6486002)(5660300001)(229853002)(6496005)(6246003)(33656002)(1411001)(54356999)(8676002)(81156014)(53936002)(189998001)(7736002)(68736007)(66066001)(106356001)(97736004)(46406003)(92566002)(4001350100001)(81166006)(47776003)(50466002)(76176999)(50986999)(86362001)(101416001)(83506001)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0501MB2833;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM4PR0501MB2833;23:MPx2xx3i93hoUn0pQ/bVCY1v3BximdTinOm3vpH?= =?us-ascii?Q?yqWN0n+JsyC3n6GQrc3g+DJxn98+9b4k5cjmnwUS0HAHY9Gg1lbAEKP1tpRM?= =?us-ascii?Q?spuAZMv6KNf5HmVNNmC6jOAsMvCwWUbq7kPMepFohPdpOaz0cYF0Ps8ENkip?= =?us-ascii?Q?MjSFzJF0mybJDkr2hjBzRIO7kckIN8E7asYHGB9jJ5eXnSA+rxgBfZOU1rSG?= =?us-ascii?Q?DF/cQ4Is4Yk6OH7dLqVhgLXUl5v4YSRAik0DXSDEc7E7UsIItc3NqXK6WC5X?= =?us-ascii?Q?qQ0lfuCDLpWJo/fSLE1IedrA4h0/2AK19nHY5p6tC/Mx9LEMhaetzpbmFCj6?= =?us-ascii?Q?Yz3f1VtCveq3udx5uyxsZX37SF5VJ0LkN81mTFGAgsRKje/OIEJFMGDPsd3Z?= =?us-ascii?Q?gfjDfPEGJ0G6JBW1LVinlTYXRkD2lGiusdur5FkIOTGJQP58bV8ku6K0vqo/?= =?us-ascii?Q?yp2lMMbIM0iGOp5h1TNI+SzMW6grvZdVqYXk23BliOGylc0QaMRLZiKir2yQ?= =?us-ascii?Q?pZT0teTdaqR+tEiGvgpUpe+oyUTvh2tFVBgQJmjwJLxfujfU3jgtoU7lGf8F?= =?us-ascii?Q?w3eFEn6HCPF1euL0t9BX0fQDhm2JC+u5BE/kxXZV7QCThoZdo3Epbh3aGDvc?= =?us-ascii?Q?aVGq34s4Qmnt99P0Yje80OSzTB8ZMurGzFpWpU3duhS/6urVhPbk8IlAkntk?= =?us-ascii?Q?ha/5gE/SzAoXaI/ROWXBcWsNxjiAPw+/1DIIP2If59evS4xgHyMBB4Sc87f7?= =?us-ascii?Q?yxVbtesa+ws6jg8g2xRXE2J/jxP9v3FM4hDaqA79+W4WQDxS3yag74q55Xmi?= =?us-ascii?Q?bs9m9IrvarNlK6EGWwQxxeOgaOmM0mRwfw9NOGFqqGf+jvWoAmXh658w3NE1?= =?us-ascii?Q?KcILguJezUXsBcLn/KFQgGwF9y0B5Y2gWLNkX2kKWJb0IVpnkXR16uuI5K3M?= =?us-ascii?Q?DMwz2geRh3qF97UaRoJvq+acB5Tor5jlOaHHlSW7dTYELvAbPcMgFXtECpIj?= =?us-ascii?Q?5qm32ZV5AlsDZX5h+ktz442Mvtt3UiNLPq+QNpUQdveK1OfAyYdR3/RBjkxX?= =?us-ascii?Q?roRz+rskmOZjuLxzl13u0gmXktqfJMvDY2Tz7uhVMSwDB3tmIZIM6BsdDgKz?= =?us-ascii?Q?x0ovDZUFMB9xZ9HFbDJGrZFd2PRqa3G/NFJIjhcaT8+177QE3X9ttPjzHSy5?= =?us-ascii?Q?yUnaG9BkZmv6F8G+qmGqSm3nMkMQ1StxLQkgjWxRi39PGPk9WCQ/0vVmUjYE?= =?us-ascii?Q?zCMPuNOTG4L/HJJpWIwCBcpoP9I/IKTmeM+/kAZXP7QUpW+YlxlX+zpJYu2z?= =?us-ascii?Q?6DHanstZKl8C6RDCpDB1IAnKnsyXZaUkTRIIPqpAOYfPqih9w3oHqT8MuCEi?= =?us-ascii?Q?EDiY1lGzovTfmgzdI66gCESySJbjVAHtuoj/XTaHZk3Ux3zbii6l9uSzkUrU?= =?us-ascii?Q?cevOFKoqnKQTl2Fke2EYo2hb3cUcvAh/VsH1inU7O+e+FhdCC7X0W?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2833;6:hKJPVC+4zWLkdeFaYLoj9YClBxGKvy8ImjfzogBW//shusCc9lgmSmEowoIioxt57eWXgkFUw8pT4Z9lUoul3JTywFgqsXzdlLUp/KgJQMEhGv92zP8a2IB++sktmjL+h72VV+wAu4sVTxub3p2sv6MSWAA0OwBM8ky7JzzHFy7rHkkgZKNP7coAmPsagQZhlNgcCWACEeV5Gmcj24fqFbdKTRsmXY3V9V+xvXovTd3fhxVJoQW+jRiT5SABEel8HDOfz5hiskevftR1ajyJAXjAExz7d2UP2gf80tBRhQYHfgf1HfPMBzO+l+2tIsQzu4Na8a/Uoegh5/fDfLpHEJiE64Ii89mnpYR/FPimzNyefwmHdCovbXu57tZJRcVfblOtGJczdtr42s6eUdW0GxhEXKW0HXnhXl6KWrnHqD0=;5:omFjvDUQQIIIaKIJ0/agNLKe6Fti46J5R2zbhKiRdBrhcqX2bfExEG6Z5dDVTUIs6UHsjRTxhTKjX9XMR+03Wf1F4ZEWufdL46EJwgi06rqhUxugF388EEoFZmRL+CFBFcPS+SkiTdhXEKr4Yn17fMzPLUYv5G+GZL4YQ14G3KM=;24:pTnkHZuPoP6dkbmAGlZClQ360bRAVZJ0sOjgRhKNvJVytofyl7FSigYeEn1Li/A+gBlFMjyEVs9bJro4eMZFWM5S5RSEMavyK59duqomoUc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2833;7:MrlxjuUpHVMGJ/f366+5sgmbwxEKyn3EHsb09tJbKnMz+nqEHNiqIuvKKOJDJN8sjhhkZdidWvP3UxEsxM0WV40mtKHwxdU4yOBEUXu1Ptb/Bb1KPJBoSWRY8UxsegNS0vZce+pauRT5ShZle9EklMRnh2h0hL5mqf4H1ZStFdoX+FrKTCDteKHDzYMmpZs8ttniPnEpRr8JYMXb5+eWBpFHP0AnDwJI5ZIAbZLGQIQQ+m+/LfZZlbJioeYd0DUiqsDlDCVfnDo8mTnvME2xX89kvsQVwcyeGwrweBRtzzKfwBRa8kSTh4mhYqbUxmC5aSGkx0DM0YwdSEaNQ7chcYaZmkCp4W5dGDQqjsOPGoZx8k3U/V6w/gHnEm2eSR6Nh1T3JdAYHzy+C878Dc4uniC4ECZV6yvs/+I8hPrbY9uBHer09Dp+QSOlJxhJDegV5gK0bVSZnVwbgaiVxO7wnEyfHNlJpH48SdS73hy8b1SKHDeia7OlspmOxXy2FIxTc9xFUyJGJQ4msz5BCJVTgQ== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2017 09:41:52.2558 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2833 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2017 at 12:07:33AM +0100, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes Reviewed-by: Ido Schimmel Tested-by: Ido Schimmel Thanks!