From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754334AbdBHLPi (ORCPT ); Wed, 8 Feb 2017 06:15:38 -0500 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:33503 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752710AbdBHLOZ (ORCPT ); Wed, 8 Feb 2017 06:14:25 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Wed, 8 Feb 2017 11:14:28 +0000 From: Charles Keepax To: Lee Jones CC: , Subject: Re: [PATCH RESEND 4/4] mfd: arizona: Use regmap_read_poll_timeout instead of hard coding it Message-ID: <20170208111428.GS1754@localhost.localdomain> References: <1485873843-8491-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1485873843-8491-4-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20170208102232.cjjqapsmhgfmwhhg@dell> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170208102232.cjjqapsmhgfmwhhg@dell> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702080111 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2017 at 10:22:32AM +0000, Lee Jones wrote: > On Tue, 31 Jan 2017, Charles Keepax wrote: > > > arizona_poll_reg essentially hard-codes regmap_read_poll_timeout, this > > patch updates the implementation to use regmap_read_poll_timeout. We > > still keep arizona_poll_reg around as regmap_read_poll_timeout is a > > macro so rather than expand this for each caller keep it wrapped in > > arizona_poll_reg. > > > > Whilst we are doing this make the timeouts a little more generous as the > > previous system had a bit more slack as it was done as a delay per > > iteration of the loop whereas regmap_read_poll_timeout compares ktime's. > > > > Signed-off-by: Charles Keepax > > --- > > drivers/mfd/arizona-core.c | 37 ++++++++++++++----------------------- > > 1 file changed, 14 insertions(+), 23 deletions(-) > > Roll this up into 3/4. > I can if you feel strongly about it but it seems much cleaner to separate the change in interface for the function and the refactoring the implementation. Thanks, Charles