From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 09/10] perf, tools: Support MetricExpr header in JSON event list
Date: Wed, 8 Feb 2017 12:31:29 +0100 [thread overview]
Message-ID: <20170208113129.GD10639@krava> (raw)
In-Reply-To: <20170128020345.19007-10-andi@firstfloor.org>
On Fri, Jan 27, 2017 at 06:03:44PM -0800, Andi Kleen wrote:
SNIP
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 82a654dec666..b78b348068d7 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -231,7 +231,8 @@ static int perf_pmu__parse_snapshot(struct perf_pmu_alias *alias,
> static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
> char *desc, char *val,
> char *long_desc, char *topic,
> - char *unit, char *perpkg)
> + char *unit, char *perpkg,
> + char *dividedby)
> {
> struct perf_pmu_alias *alias;
> int ret;
> @@ -265,6 +266,7 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
> perf_pmu__parse_snapshot(alias, dir, name);
> }
>
> + alias->dividedby = dividedby ? strdup(dividedby) : NULL;
s/dividedby/metric_expr/ ?
CC util/pmu.o
util/pmu.c: In function ‘pmu_add_cpu_aliases’:
util/pmu.c:570:15: error: ‘struct pmu_event’ has no member named ‘dividedby’
(char *)pe->dividedby);
> alias->desc = desc ? strdup(desc) : NULL;
> alias->long_desc = long_desc ? strdup(long_desc) :
> desc ? strdup(desc) : NULL;
> @@ -294,7 +296,7 @@ static int perf_pmu__new_alias(struct list_head *list, char *dir, char *name, FI
> buf[ret] = 0;
>
> return __perf_pmu__new_alias(list, dir, name, NULL, buf, NULL, NULL, NULL,
> - NULL);
> + NULL, NULL);
> }
>
> static inline bool pmu_alias_info_file(char *name)
> @@ -564,7 +566,8 @@ static void pmu_add_cpu_aliases(struct list_head *head, const char *name)
> __perf_pmu__new_alias(head, NULL, (char *)pe->name,
> (char *)pe->desc, (char *)pe->event,
> (char *)pe->long_desc, (char *)pe->topic,
> - (char *)pe->unit, (char *)pe->perpkg);
> + (char *)pe->unit, (char *)pe->perpkg,
> + (char *)pe->dividedby);
ditto
> }
>
> out:
> diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
> index 00852ddc7741..faf8a7f97d03 100644
> --- a/tools/perf/util/pmu.h
> +++ b/tools/perf/util/pmu.h
> @@ -50,6 +50,7 @@ struct perf_pmu_alias {
> double scale;
> bool per_pkg;
> bool snapshot;
> + char *dividedby;
ditto
> };
>
> struct perf_pmu *perf_pmu__find(const char *name);
> --
> 2.9.3
>
next prev parent reply other threads:[~2017-02-08 11:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 2:03 Support Intel uncore event lists Andi Kleen
2017-01-28 2:03 ` [PATCH 01/10] perf, tools: Parse eventcode as number in jevents Andi Kleen
2017-02-10 7:41 ` [tip:perf/core] perf jevents: Parse eventcode as number tip-bot for Andi Kleen
2017-01-28 2:03 ` [PATCH 02/10] perf, tools: Add support for parsing uncore json files Andi Kleen
2017-02-10 7:41 ` [tip:perf/core] perf jevents: " tip-bot for Andi Kleen
2017-01-28 2:03 ` [PATCH 03/10] perf, tools: Support per pmu json aliases Andi Kleen
2017-02-10 7:42 ` [tip:perf/core] perf pmu: " tip-bot for Andi Kleen
2017-01-28 2:03 ` [PATCH 04/10] perf, tools: Support event aliases for non cpu// pmus Andi Kleen
2017-02-10 7:42 ` [tip:perf/core] perf pmu: " tip-bot for Andi Kleen
2017-01-28 2:03 ` [PATCH 05/10] perf, tools: Add debug support for outputing alias string Andi Kleen
2017-02-10 7:43 ` [tip:perf/core] perf list: " tip-bot for Andi Kleen
2017-01-28 2:03 ` [PATCH 06/10] perf, tools: Collapse identically named events in perf stat Andi Kleen
2017-02-08 11:31 ` Jiri Olsa
2017-01-28 2:03 ` [PATCH 07/10] perf, tools: Expand PMU events by prefix match Andi Kleen
2017-02-08 11:30 ` Jiri Olsa
2017-01-28 2:03 ` [PATCH 08/10] perf, tools: Add a simple expression parser for JSON Andi Kleen
2017-02-08 11:31 ` Jiri Olsa
2017-01-28 2:03 ` [PATCH 09/10] perf, tools: Support MetricExpr header in JSON event list Andi Kleen
2017-02-08 11:31 ` Jiri Olsa [this message]
2017-01-28 2:03 ` [PATCH 10/10] perf, tools, stat: Output JSON MetricExpr metric Andi Kleen
2017-02-08 11:31 ` Jiri Olsa
2017-02-08 21:51 ` Andi Kleen
2017-02-09 11:39 ` Jiri Olsa
2017-02-09 17:00 ` Andi Kleen
2017-02-09 18:37 ` Jiri Olsa
2017-02-09 18:59 ` Andi Kleen
2017-02-10 8:22 ` Jiri Olsa
2017-02-09 11:42 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208113129.GD10639@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox