From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932842AbdBHLbp (ORCPT ); Wed, 8 Feb 2017 06:31:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59734 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754090AbdBHLbm (ORCPT ); Wed, 8 Feb 2017 06:31:42 -0500 Date: Wed, 8 Feb 2017 12:31:29 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 09/10] perf, tools: Support MetricExpr header in JSON event list Message-ID: <20170208113129.GD10639@krava> References: <20170128020345.19007-1-andi@firstfloor.org> <20170128020345.19007-10-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170128020345.19007-10-andi@firstfloor.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 08 Feb 2017 11:31:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 27, 2017 at 06:03:44PM -0800, Andi Kleen wrote: SNIP > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > index 82a654dec666..b78b348068d7 100644 > --- a/tools/perf/util/pmu.c > +++ b/tools/perf/util/pmu.c > @@ -231,7 +231,8 @@ static int perf_pmu__parse_snapshot(struct perf_pmu_alias *alias, > static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name, > char *desc, char *val, > char *long_desc, char *topic, > - char *unit, char *perpkg) > + char *unit, char *perpkg, > + char *dividedby) > { > struct perf_pmu_alias *alias; > int ret; > @@ -265,6 +266,7 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name, > perf_pmu__parse_snapshot(alias, dir, name); > } > > + alias->dividedby = dividedby ? strdup(dividedby) : NULL; s/dividedby/metric_expr/ ? CC util/pmu.o util/pmu.c: In function ‘pmu_add_cpu_aliases’: util/pmu.c:570:15: error: ‘struct pmu_event’ has no member named ‘dividedby’ (char *)pe->dividedby); > alias->desc = desc ? strdup(desc) : NULL; > alias->long_desc = long_desc ? strdup(long_desc) : > desc ? strdup(desc) : NULL; > @@ -294,7 +296,7 @@ static int perf_pmu__new_alias(struct list_head *list, char *dir, char *name, FI > buf[ret] = 0; > > return __perf_pmu__new_alias(list, dir, name, NULL, buf, NULL, NULL, NULL, > - NULL); > + NULL, NULL); > } > > static inline bool pmu_alias_info_file(char *name) > @@ -564,7 +566,8 @@ static void pmu_add_cpu_aliases(struct list_head *head, const char *name) > __perf_pmu__new_alias(head, NULL, (char *)pe->name, > (char *)pe->desc, (char *)pe->event, > (char *)pe->long_desc, (char *)pe->topic, > - (char *)pe->unit, (char *)pe->perpkg); > + (char *)pe->unit, (char *)pe->perpkg, > + (char *)pe->dividedby); ditto > } > > out: > diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h > index 00852ddc7741..faf8a7f97d03 100644 > --- a/tools/perf/util/pmu.h > +++ b/tools/perf/util/pmu.h > @@ -50,6 +50,7 @@ struct perf_pmu_alias { > double scale; > bool per_pkg; > bool snapshot; > + char *dividedby; ditto > }; > > struct perf_pmu *perf_pmu__find(const char *name); > -- > 2.9.3 >