From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933096AbdBHNJ0 (ORCPT ); Wed, 8 Feb 2017 08:09:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32882 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754575AbdBHNIy (ORCPT ); Wed, 8 Feb 2017 08:08:54 -0500 Date: Wed, 8 Feb 2017 13:57:32 +0100 From: Jiri Olsa To: Hari Bathini Cc: ast@fb.com, peterz@infradead.org, lkml , acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, daniel@iogearbox.net, rostedt@goodmis.org, Ananth N Mavinakayanahalli , ebiederm@xmission.com, sargun@sargun.me, Aravinda Prasad , brendan.d.gregg@gmail.com Subject: Re: [PATCH v6 2/3] perf tool: add PERF_RECORD_NAMESPACES to include namespaces related info Message-ID: <20170208125732.GC22166@krava> References: <148654265580.27983.8822211570127163843.stgit@hbathini.in.ibm.com> <148654270963.27983.11333098688761605858.stgit@hbathini.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <148654270963.27983.11333098688761605858.stgit@hbathini.in.ibm.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 08 Feb 2017 12:57:37 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2017 at 02:01:49PM +0530, Hari Bathini wrote: > This patch updates perf tool to examine PERF_RECORD_NAMESPACES events > emitted by the kernel when fork, clone, setns or unshare are invoked. > Also, it synthesizes PERF_RECORD_NAMESPACES events for processes that > were running prior to invocation of perf record, the data for which > is taken from /proc/$PID/ns. These changes make way for analyzing > events with regard to namespaces. > > Signed-off-by: Hari Bathini > --- > tools/include/uapi/linux/perf_event.h | 38 +++++++++ > tools/perf/builtin-annotate.c | 1 > tools/perf/builtin-diff.c | 1 > tools/perf/builtin-inject.c | 14 +++ > tools/perf/builtin-kmem.c | 1 > tools/perf/builtin-kvm.c | 2 > tools/perf/builtin-lock.c | 1 > tools/perf/builtin-mem.c | 1 > tools/perf/builtin-record.c | 33 +++++++- > tools/perf/builtin-report.c | 1 > tools/perf/builtin-sched.c | 1 > tools/perf/builtin-script.c | 41 +++++++++ > tools/perf/builtin-trace.c | 3 - > tools/perf/perf.h | 1 > tools/perf/util/Build | 1 > tools/perf/util/data-convert-bt.c | 2 > tools/perf/util/event.c | 143 ++++++++++++++++++++++++++++++++- > tools/perf/util/event.h | 19 ++++ > tools/perf/util/evsel.c | 3 + > tools/perf/util/machine.c | 34 ++++++++ > tools/perf/util/machine.h | 3 + > tools/perf/util/namespaces.c | 35 ++++++++ > tools/perf/util/namespaces.h | 26 ++++++ > tools/perf/util/session.c | 7 ++ > tools/perf/util/thread.c | 44 ++++++++++ > tools/perf/util/thread.h | 6 + > tools/perf/util/tool.h | 2 > 27 files changed, 450 insertions(+), 14 deletions(-) > create mode 100644 tools/perf/util/namespaces.c > create mode 100644 tools/perf/util/namespaces.h could you please split this patch into logically separated changes, like: - adding PERF_RECORD_NAMESPACES event with perf_event__process_namespaces machinery - synthesize support (perf_event__synthesize_namespaces) for record - script print support - perf_event__fprintf print support or any other split that'd make sense, it's too many changes for one patch now thanks, jirka