From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753499AbdBHQAv (ORCPT ); Wed, 8 Feb 2017 11:00:51 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:29318 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618AbdBHQAd (ORCPT ); Wed, 8 Feb 2017 11:00:33 -0500 Date: Wed, 8 Feb 2017 07:59:47 -0800 From: Sowmini Varadhan To: Shannon Nelson Cc: netdev@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic Message-ID: <20170208155947.GE30741@oracle.com> References: <1486505582-76823-1-git-send-email-shannon.nelson@oracle.com> <1486505582-76823-7-git-send-email-shannon.nelson@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486505582-76823-7-git-send-email-shannon.nelson@oracle.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (02/07/17 14:12), Shannon Nelson wrote: > + > + /* we don't expect any other bits */ > + BUG_ON(port->rx_event & ~(LDC_EVENT_DATA_READY | > + LDC_EVENT_RESET | > + LDC_EVENT_UP)); > + > + /* RESET takes precedent over any other event */ > + if (port->rx_event & LDC_EVENT_RESET) { : > port->rx_event = 0; > return 0; > } > + if (port->rx_event & LDC_EVENT_UP) { > + vio_link_state_change(vio, LDC_EVENT_UP); > + port->rx_event = 0; > + return 0; > + } > > err = 0; > tx_wakeup = 0; IIRC there were timing-related situations where you can get woken up with both UP and DATA_READY, and if my reading of your patch is correct, we would ignore the DATA_READY, and return, right? --Sowmini