From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753700AbdBHQf4 (ORCPT ); Wed, 8 Feb 2017 11:35:56 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:25869 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751859AbdBHQfp (ORCPT ); Wed, 8 Feb 2017 11:35:45 -0500 Date: Wed, 8 Feb 2017 08:34:51 -0800 From: Sowmini Varadhan To: Shannon Nelson Cc: netdev@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic Message-ID: <20170208163451.GF30741@oracle.com> References: <1486505582-76823-1-git-send-email-shannon.nelson@oracle.com> <1486505582-76823-7-git-send-email-shannon.nelson@oracle.com> <20170208155947.GE30741@oracle.com> <792566dd-8f05-ed1b-50ad-d40f958aa2c7@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <792566dd-8f05-ed1b-50ad-d40f958aa2c7@oracle.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (02/08/17 08:28), Shannon Nelson wrote: > The existing code does this as well - if it first finds a RESET, it handles > it then hits the return 0. Next if it finds the UP, it does the goto back > to the ldc_ctrl: to process, and hits the same return 0. Only if neither of > these bits have been seen does the code move on to process the DATA_READY > event. > > If we're seeing cases of both UP and DATA_READY, then yes we'll wnat to look > at changing this logic. I think that should be a separate patch. > Ok. probably we just make one redundant loop out and back into the function. Other than that, the patchset looks good to me. --Sowmini