From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751302AbdBIBsf (ORCPT ); Wed, 8 Feb 2017 20:48:35 -0500 Received: from mail.kernel.org ([198.145.29.136]:56744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbdBIBse (ORCPT ); Wed, 8 Feb 2017 20:48:34 -0500 Date: Thu, 9 Feb 2017 09:48:09 +0800 From: Shawn Guo To: Rob Herring Cc: Baoyou Xie , lgirdwood@gmail.com, broonie@kernel.org, mark.rutland@arm.com, jun.nie@linaro.org, mturquette@baylibre.com, sboyd@codeaurora.org, perex@perex.cz, tiwai@suse.com, shawn.guo@linaro.org, vinod.koul@intel.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, mathieu.poirier@linaro.org, xie.baoyou@zte.com.cn, chen.chaokai@zte.com.cn, wang.qiang01@zte.com.cn Subject: Re: [PATCH v3 2/3] ASoC: zx-i2s: introduce pclk for zx2967 family Message-ID: <20170209014807.GO3407@dragon> References: <1486522955-14528-1-git-send-email-baoyou.xie@linaro.org> <1486522955-14528-2-git-send-email-baoyou.xie@linaro.org> <20170209005207.y6wcrzk43ngfslhl@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170209005207.y6wcrzk43ngfslhl@rob-hp-laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2017 at 06:52:07PM -0600, Rob Herring wrote: > On Wed, Feb 08, 2017 at 11:02:34AM +0800, Baoyou Xie wrote: > > ZTE's zx2967 I2S controller driver introduces pclk, this > > patch documents this fact. > > Now we have the same subject for patches 2 and 3. > > Personally, I'd prefer "dt-bindings: sound: blah...", but not enough to > argue with Mark about it. If that is not the prefix, then it should at > least have "binding" in the subject. +1 The prefix of sound bindings is quite unique from other subsystems. Looking at the prefix of Documentation/devicetree/bindings/sound/ commits, I'm always confused whether it's a pure binding commit or just submitted as part of the driver patch. I feel that we kinda lose the point of having a prefix. Just my 2 cents. Shawn