From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751674AbdBIINE (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Feb 2017 03:13:04 -0500
Received: from LGEAMRELO11.lge.com ([156.147.23.51]:38960 "EHLO
        lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751573AbdBIINC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Feb 2017 03:13:02 -0500
X-Original-SENDERIP: 156.147.1.126
X-Original-MAILFROM: minchan@kernel.org
X-Original-SENDERIP: 165.244.249.25
X-Original-MAILFROM: minchan@kernel.org
X-Original-SENDERIP: 10.177.223.161
X-Original-MAILFROM: minchan@kernel.org
Date: Thu, 9 Feb 2017 17:09:17 +0900
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
CC: Yisheng Xie <xieyisheng1@huawei.com>, <akpm@linux-foundation.org>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <sergey.senozhatsky@gmail.com>, <ngupta@vflare.org>,
        <guohanjun@huawei.com>
Subject: Re: [PATCH v2] mm/zsmalloc: fix comment in zsmalloc
Message-ID: <20170209080917.GA23016@bbox>
References: <1486620822-36826-1-git-send-email-xieyisheng1@huawei.com>
 <20170209070543.GA9995@jagdpanzerIV.localdomain>
MIME-Version: 1.0
In-Reply-To: <20170209070543.GA9995@jagdpanzerIV.localdomain>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB06/LGE/LG Group(Release 8.5.3FP6|November
 21, 2013) at 2017/02/09 17:09:18,
        Serialize by Router on LGEKRMHUB06/LGE/LG Group(Release 8.5.3FP6|November
 21, 2013) at 2017/02/09 17:09:18,
        Serialize complete at 2017/02/09 17:09:18
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 09, 2017 at 04:05:43PM +0900, Sergey Senozhatsky wrote:
> On (02/09/17 14:13), Yisheng Xie wrote:
> > The class index and fullness group are not encoded in (first)page->mapping
> > any more, after commit 3783689a1aa8 ("zsmalloc: introduce zspage
> > structure"). Instead, they are store in struct zspage. Just delete this
> > unneeded comment.
> > 
> > Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> > Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Cc: Minchan Kim <minchan@kernel.org>
> > Cc: Nitin Gupta <ngupta@vflare.org>
> > Cc: Hanjun Guo <guohanjun@huawei.com>
Acked-by: Minchan Kim <minchan@kernel.org>

> > ---
> > v2:
> >  * just delete the comment for it is no need anymore, suggested by Sergey.
> 
> thanks for the patch.
> 
> my "suggestion" was just a side note, nothing more. I'm fine with the
> "fix the comment" patch that Andrew has added to mmotm.
> we need Minchan's opinion on this, until he speaks out let's have V1
> ("fix the comment") applied.

I agree on Sergey's opinion.

Andrew,
Please drop previous patch and replace it with this.

Thanks.