From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752397AbdBIKLe (ORCPT ); Thu, 9 Feb 2017 05:11:34 -0500 Received: from merlin.infradead.org ([205.233.59.134]:57556 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884AbdBIKLd (ORCPT ); Thu, 9 Feb 2017 05:11:33 -0500 Date: Thu, 9 Feb 2017 11:11:26 +0100 From: Peter Zijlstra To: Mars Cheng Cc: Ingo Molnar , CC Hwang , Loda Chou , Miles Chen , Jades Shih , Yingjoe Chen , My Chuang , linux-kernel@vger.kernel.org, wsd_upstream@mediatek.com Subject: Re: [PATCH] perf/core: remove useless cast when comparing Message-ID: <20170209101126.GA6500@twins.programming.kicks-ass.net> References: <1486628746-23538-1-git-send-email-mars.cheng@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486628746-23538-1-git-send-email-mars.cheng@mediatek.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 09, 2017 at 04:25:46PM +0800, Mars Cheng wrote: > since nr_cpu_ids and cpu are both int, remove the casting Please as to learn C before playing. Consider negative numbers.