From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752558AbdBILUy (ORCPT ); Thu, 9 Feb 2017 06:20:54 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:41120 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174AbdBILUw (ORCPT ); Thu, 9 Feb 2017 06:20:52 -0500 Date: Thu, 9 Feb 2017 12:04:33 +0100 From: Greg KH To: Karthik Nayak Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, kastolom@gmail.com, abbotti@mev.co.uk Subject: Re: [PATCH] staging: comedi: Fix incorrect type assignment Message-ID: <20170209110433.GA31689@kroah.com> References: <20170208202356.5662-1-Karthik.188@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170208202356.5662-1-Karthik.188@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 09, 2017 at 01:53:56AM +0530, Karthik Nayak wrote: > This patch fixes the following sparse error: > drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types) > drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: expected restricted __be32 [usertype] serial_number > drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: got unsigned int > > This is done by removing the whole code block, since the variable > 'serial_number' is only assigned but never used. > > Helped-by: Ian Abbott There's no such tag, sorry :( And does this obsolete all of your other ones? Please make it obvious what I am supposed to do here. I've now dropped all of these patches from my queue. please resend the proper one. thanks, greg k-h