From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 10/10] perf, tools, stat: Output JSON MetricExpr metric
Date: Thu, 9 Feb 2017 12:39:37 +0100 [thread overview]
Message-ID: <20170209113937.GA7455@krava> (raw)
In-Reply-To: <20170208215103.GP26852@two.firstfloor.org>
On Wed, Feb 08, 2017 at 01:51:05PM -0800, Andi Kleen wrote:
SNIP
> >
> > could you show an example of the MetricExpr?
>
> It's in the event list branch
>
> https://git.kernel.org/cgit/linux/kernel/git/ak/linux-misc.git/log/?h=perf/intel-uncore-json-files-3
>
> All the metrics currently do is just the same as DividedBy earlier:
> generate a percentage out of a count, typically based on clock ticks.
>
> + "MetricExpr": "(UNC_M_POWER_CHANNEL_PPD / UNC_M_CLOCKTICKS) *
> 100.",
>
>
>
> >
> > it's part of the event record, what if you wanted to have 2 or more metrics defined for event?
>
> Would need multiple copies of the event.
this ...
>
> >
> > who defines those expressions?
>
> It's metrics used internally by Intel.
>
> >
> > what if you dont provide the necessary events needed for the expression?
>
> Then perf prints a warning suggesting the events.
>
> It's currently a TODO to add them automatically. Could be added,
> but the patch was already complex, so I didn't add it.
>
> It's somewhat complicated because you would need to avoid
> duplicates and have to handle groups correctly. perf stat
> doesn't have the necessarily knowledge to fully understand
> the constraints on groups.
>
> Then the extra event may not fit into the group, and it seemed
> saner to let the user decide what to do then, instead of
> generating a possible unschedulable group.
>
> So it's not that easy to do it automatically.
and this makes me think, that this is not the right approach
adding extra copy of an event when you want to add new expression?
why can't we have another list/file of those expressions
from which point we could point and configure events we need
jirka
next prev parent reply other threads:[~2017-02-09 11:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 2:03 Support Intel uncore event lists Andi Kleen
2017-01-28 2:03 ` [PATCH 01/10] perf, tools: Parse eventcode as number in jevents Andi Kleen
2017-02-10 7:41 ` [tip:perf/core] perf jevents: Parse eventcode as number tip-bot for Andi Kleen
2017-01-28 2:03 ` [PATCH 02/10] perf, tools: Add support for parsing uncore json files Andi Kleen
2017-02-10 7:41 ` [tip:perf/core] perf jevents: " tip-bot for Andi Kleen
2017-01-28 2:03 ` [PATCH 03/10] perf, tools: Support per pmu json aliases Andi Kleen
2017-02-10 7:42 ` [tip:perf/core] perf pmu: " tip-bot for Andi Kleen
2017-01-28 2:03 ` [PATCH 04/10] perf, tools: Support event aliases for non cpu// pmus Andi Kleen
2017-02-10 7:42 ` [tip:perf/core] perf pmu: " tip-bot for Andi Kleen
2017-01-28 2:03 ` [PATCH 05/10] perf, tools: Add debug support for outputing alias string Andi Kleen
2017-02-10 7:43 ` [tip:perf/core] perf list: " tip-bot for Andi Kleen
2017-01-28 2:03 ` [PATCH 06/10] perf, tools: Collapse identically named events in perf stat Andi Kleen
2017-02-08 11:31 ` Jiri Olsa
2017-01-28 2:03 ` [PATCH 07/10] perf, tools: Expand PMU events by prefix match Andi Kleen
2017-02-08 11:30 ` Jiri Olsa
2017-01-28 2:03 ` [PATCH 08/10] perf, tools: Add a simple expression parser for JSON Andi Kleen
2017-02-08 11:31 ` Jiri Olsa
2017-01-28 2:03 ` [PATCH 09/10] perf, tools: Support MetricExpr header in JSON event list Andi Kleen
2017-02-08 11:31 ` Jiri Olsa
2017-01-28 2:03 ` [PATCH 10/10] perf, tools, stat: Output JSON MetricExpr metric Andi Kleen
2017-02-08 11:31 ` Jiri Olsa
2017-02-08 21:51 ` Andi Kleen
2017-02-09 11:39 ` Jiri Olsa [this message]
2017-02-09 17:00 ` Andi Kleen
2017-02-09 18:37 ` Jiri Olsa
2017-02-09 18:59 ` Andi Kleen
2017-02-10 8:22 ` Jiri Olsa
2017-02-09 11:42 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209113937.GA7455@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox