From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752558AbdBIXRi (ORCPT ); Thu, 9 Feb 2017 18:17:38 -0500 Received: from mail-pf0-f176.google.com ([209.85.192.176]:36411 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752483AbdBIXRh (ORCPT ); Thu, 9 Feb 2017 18:17:37 -0500 Date: Thu, 9 Feb 2017 15:17:29 -0800 From: Stephen Hemminger To: Thomas Gleixner Cc: Stephen Hemminger , Haiyang Zhang , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Andy Lutomirski , Ingo Molnar , "H. Peter Anvin" , "devel@linuxdriverproject.org" , "virtualization@lists.linux-foundation.org" Subject: Re: [PATCH 1/2] hyperv: implement hv_get_tsc_page() Message-ID: <20170209151729.6c88b779@xeon-e3> In-Reply-To: References: <20170209141052.18694-1-vkuznets@redhat.com> <20170209141052.18694-2-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 9 Feb 2017 21:14:25 +0100 (CET) Thomas Gleixner wrote: > On Thu, 9 Feb 2017, Stephen Hemminger wrote: > > > The actual code looks fine, but the style police will not like you. > > { should be at start of line on functions. > > And #else should be at start of line, > > > > But maybe this was just more of exchange mangling the mail. > > Looks like. > > > +struct ms_hyperv_tsc_page *hv_get_tsc_page(void) { > > + return tsc_pg; > > +} > > + > > That's how it reads in a proper mail client connected to a proper mail > server: > > > +struct ms_hyperv_tsc_page *hv_get_tsc_page(void) > > +{ > > + return tsc_pg; > > +} > > :) Yup. it looks like the mail server is trying to be "helpful" by eliminating extra white space.