From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754099AbdBITLA (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Feb 2017 14:11:00 -0500
Received: from mail-wm0-f67.google.com ([74.125.82.67]:32906 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752582AbdBITK6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Feb 2017 14:10:58 -0500
Date: Thu, 9 Feb 2017 19:09:12 +0000
From: Abel Vesa <abelvesa@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
        Abel Vesa <abelvesa@linux.com>, mingo@redhat.com,
        viro@zeniv.linux.org.uk, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, jjhiblot@traphandler.com,
        pmladek@suse.com, robin.murphy@arm.com, zhouchengming1@huawei.com,
        Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCHv3] arm: ftrace: Adds support for
 CONFIG_DYNAMIC_FTRACE_WITH_REGS
Message-ID: <20170209190912.GD3439@nuc>
References: <1486508275-18449-1-git-send-email-abelvesa@linux.com>
 <20170209162956.GH27312@n2100.armlinux.org.uk>
 <20170209121322.5229e6cf@gandalf.local.home>
 <20170209180644.GJ27312@n2100.armlinux.org.uk>
 <20170209131414.098c848c@gandalf.local.home>
 <20170209131452.472aa882@gandalf.local.home>
 <20170209190110.GC3439@nuc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170209190110.GC3439@nuc>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 09, 2017 at 07:01:10PM +0000, Abel Vesa wrote:
> On Thu, Feb 09, 2017 at 01:14:52PM -0500, Steven Rostedt wrote:
> > 
> > [ sending again with Masami Cc'd ]
> > 
> > On Thu, 9 Feb 2017 13:14:14 -0500
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> > 
> > > On Thu, 9 Feb 2017 18:06:44 +0000
> > > Russell King - ARM Linux <linux@armlinux.org.uk> wrote:
> > > 
> > > > On Thu, Feb 09, 2017 at 12:13:22PM -0500, Steven Rostedt wrote:  
> > > > > Then came along live kernel patching, which I believe this series is
> > > > > trying to support. What is needed by pt_regs is a way to "hijack" the
> > > > > function being called to instead call the patched function. That is,
> > > > > ftrace is not being used for tracing, but in reality, being used to
> > > > > modify the running kernel. It is being used to change what function
> > > > > gets called. ftrace is just a hook for that mechanism.    
> > > > 
> > > > So, would I be correct to assume that the only parts of pt_regs that
> > > > would be touched are those which contain arguments to the function,
> > > > and the register which would contain the return value?
> > > >   
> > > 
> > > For live kernel patching, perhaps.
> > > 
> > > But for kprobes, I think they can touch anything. Matters what the
> > > creater of the kprobe wanted to do.
> > > 
> Thing is, by saving all of them is the easiest way to ensure that the
> whole context is the same when the replacing function gets called, as
> I said before.
> 
> We can't be sure that while __ftrace_ops_list_func is executing, any of
> the regs will have the value they had when the function-to-be-replaced
> was called. That's the reason I say we need to save them all.
Scratch that, I'm wrong, the reason is stupid. The context gets restored anyway after
__ftrace_ops_list_func is done.
> > > -- Steve
> >