From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752660AbdBIXAT (ORCPT ); Thu, 9 Feb 2017 18:00:19 -0500 Received: from mga09.intel.com ([134.134.136.24]:26966 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbdBIXAQ (ORCPT ); Thu, 9 Feb 2017 18:00:16 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,138,1484035200"; d="scan'208";a="1105370208" Date: Thu, 9 Feb 2017 14:59:27 -0800 From: Andi Kleen To: Adrian Hunter Cc: Andi Kleen , peterz@infradead.org, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] perf tools: Support end symbols with no size for filters Message-ID: <20170209225927.GB15301@tassilo.jf.intel.com> References: <20170203221830.22354-1-andi@firstfloor.org> <20170203221830.22354-2-andi@firstfloor.org> <33fb6f80-a355-d093-0237-f8cb39ab0de7@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33fb6f80-a355-d093-0237-f8cb39ab0de7@intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > - no_size = !!size; > > Erk! Isn't the logic is the wrong way around here. Sorry! > i.e. should be: Yes it works with that change too. > > diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c > index c5a6e0b12452..78bd632f144d 100644 > --- a/tools/perf/util/auxtrace.c > +++ b/tools/perf/util/auxtrace.c > @@ -1826,7 +1826,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt) > filt->addr = start; > if (filt->range && !filt->size && !filt->sym_to) { > filt->size = size; > - no_size = !!size; > + no_size = !size; > } > } > > @@ -1840,7 +1840,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt) > if (err) > return err; > filt->size = start + size - filt->addr; > - no_size = !!size; > + no_size = !size; > } >