public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Wei Yongjun <weiyongjun1@huawei.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] x86/intel_rdt: Remove duplicated include from intel_rdt_rdtgroup.c
Date: Fri, 10 Feb 2017 09:20:27 +0100	[thread overview]
Message-ID: <20170210082027.GA20691@gmail.com> (raw)
In-Reply-To: <20170209153131.2536-1-weiyj.lk@gmail.com>


* Wei Yongjun <weiyj.lk@gmail.com> wrote:

> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Remove duplicated include.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> index 8af04af..759577d 100644
> --- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> +++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
> @@ -27,7 +27,6 @@
>  #include <linux/seq_file.h>
>  #include <linux/sched.h>
>  #include <linux/slab.h>
> -#include <linux/cpu.h>
>  #include <linux/task_work.h>
>  
>  #include <uapi/linux/magic.h>

Same comment as for your other trivial patch: the list of includes in that .c file 
can probably be further reduced.

I.e. instead of a mindless single liner that helps no-one, try to improve the code 
for real.

Thanks,

	Ingo

      reply	other threads:[~2017-02-10  8:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09 15:31 [PATCH -next] x86/intel_rdt: Remove duplicated include from intel_rdt_rdtgroup.c Wei Yongjun
2017-02-10  8:20 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170210082027.GA20691@gmail.com \
    --to=mingo@kernel.org \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=weiyj.lk@gmail.com \
    --cc=weiyongjun1@huawei.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox