From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752467AbdBJQyP (ORCPT ); Fri, 10 Feb 2017 11:54:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54018 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751924AbdBJQyN (ORCPT ); Fri, 10 Feb 2017 11:54:13 -0500 Date: Fri, 10 Feb 2017 20:37:55 +0800 From: Baoquan He To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, x86@kernel.org, mingo@redhat.com, hpa@zytor.com Subject: Re: [PATCH] x86: Clean up a tiny description mistake in kernel ld script Message-ID: <20170210123755.GA1770@x1> References: <1486041922-5515-1-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 10 Feb 2017 12:37:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/10/17 at 12:46pm, Thomas Gleixner wrote: > On Thu, 2 Feb 2017, Baoquan He wrote: > > > Remove the redundent word "is". > > > > Signed-off-by: Baoquan He > > --- > > arch/x86/kernel/vmlinux.lds.S | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S > > index e79f15f..f8f56b9 100644 > > --- a/arch/x86/kernel/vmlinux.lds.S > > +++ b/arch/x86/kernel/vmlinux.lds.S > > @@ -8,8 +8,8 @@ > > * > > * > > * Don't define absolute symbols until and unless you know that symbol > > - * value is should remain constant even if kernel image is relocated > > - * at run time. Absolute symbols are not relocated. If symbol value should > > + * value should remain constant even if kernel image is relocated at > > And while at it we could make it a proper sentence: > > ... you know that the symbol value should .... even if the kernel .... > > > + * run time. Absolute symbols are not relocated. If symbol value should > > If the symbol value ... > > > * change if kernel is relocated, make the symbol section relative and > > if the kernel Yes, I missed these, let me post v2. Thanks! > > > * put it inside the section definition. > > */ > > -- > > 2.5.5 > > > >