* [PATCH] x86: Clean up a tiny description mistake in kernel ld script
@ 2017-02-02 13:25 Baoquan He
2017-02-10 11:46 ` Thomas Gleixner
0 siblings, 1 reply; 4+ messages in thread
From: Baoquan He @ 2017-02-02 13:25 UTC (permalink / raw)
To: linux-kernel, x86; +Cc: mingo, tglx, hpa, Baoquan He
Remove the redundent word "is".
Signed-off-by: Baoquan He <bhe@redhat.com>
---
arch/x86/kernel/vmlinux.lds.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index e79f15f..f8f56b9 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -8,8 +8,8 @@
*
*
* Don't define absolute symbols until and unless you know that symbol
- * value is should remain constant even if kernel image is relocated
- * at run time. Absolute symbols are not relocated. If symbol value should
+ * value should remain constant even if kernel image is relocated at
+ * run time. Absolute symbols are not relocated. If symbol value should
* change if kernel is relocated, make the symbol section relative and
* put it inside the section definition.
*/
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: Clean up a tiny description mistake in kernel ld script
2017-02-02 13:25 [PATCH] x86: Clean up a tiny description mistake in kernel ld script Baoquan He
@ 2017-02-10 11:46 ` Thomas Gleixner
2017-02-10 12:37 ` Baoquan He
2017-02-10 12:51 ` [PATCH v2] " Baoquan He
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Gleixner @ 2017-02-10 11:46 UTC (permalink / raw)
To: Baoquan He; +Cc: linux-kernel, x86, mingo, hpa
On Thu, 2 Feb 2017, Baoquan He wrote:
> Remove the redundent word "is".
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
> arch/x86/kernel/vmlinux.lds.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> index e79f15f..f8f56b9 100644
> --- a/arch/x86/kernel/vmlinux.lds.S
> +++ b/arch/x86/kernel/vmlinux.lds.S
> @@ -8,8 +8,8 @@
> *
> *
> * Don't define absolute symbols until and unless you know that symbol
> - * value is should remain constant even if kernel image is relocated
> - * at run time. Absolute symbols are not relocated. If symbol value should
> + * value should remain constant even if kernel image is relocated at
And while at it we could make it a proper sentence:
... you know that the symbol value should .... even if the kernel ....
> + * run time. Absolute symbols are not relocated. If symbol value should
If the symbol value ...
> * change if kernel is relocated, make the symbol section relative and
if the kernel
> * put it inside the section definition.
> */
> --
> 2.5.5
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: Clean up a tiny description mistake in kernel ld script
2017-02-10 11:46 ` Thomas Gleixner
@ 2017-02-10 12:37 ` Baoquan He
2017-02-10 12:51 ` [PATCH v2] " Baoquan He
1 sibling, 0 replies; 4+ messages in thread
From: Baoquan He @ 2017-02-10 12:37 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: linux-kernel, x86, mingo, hpa
On 02/10/17 at 12:46pm, Thomas Gleixner wrote:
> On Thu, 2 Feb 2017, Baoquan He wrote:
>
> > Remove the redundent word "is".
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > ---
> > arch/x86/kernel/vmlinux.lds.S | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> > index e79f15f..f8f56b9 100644
> > --- a/arch/x86/kernel/vmlinux.lds.S
> > +++ b/arch/x86/kernel/vmlinux.lds.S
> > @@ -8,8 +8,8 @@
> > *
> > *
> > * Don't define absolute symbols until and unless you know that symbol
> > - * value is should remain constant even if kernel image is relocated
> > - * at run time. Absolute symbols are not relocated. If symbol value should
> > + * value should remain constant even if kernel image is relocated at
>
> And while at it we could make it a proper sentence:
>
> ... you know that the symbol value should .... even if the kernel ....
>
> > + * run time. Absolute symbols are not relocated. If symbol value should
>
> If the symbol value ...
>
> > * change if kernel is relocated, make the symbol section relative and
>
> if the kernel
Yes, I missed these, let me post v2. Thanks!
>
> > * put it inside the section definition.
> > */
> > --
> > 2.5.5
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] x86: Clean up a tiny description mistake in kernel ld script
2017-02-10 11:46 ` Thomas Gleixner
2017-02-10 12:37 ` Baoquan He
@ 2017-02-10 12:51 ` Baoquan He
1 sibling, 0 replies; 4+ messages in thread
From: Baoquan He @ 2017-02-10 12:51 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: linux-kernel, x86, mingo, hpa
Remove the redundent word "is". And add several missing definite
article 'the'.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
arch/x86/kernel/vmlinux.lds.S | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index e79f15f..44d7eaa 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -7,10 +7,10 @@
* Copyright (C) 2007-2009 Sam Ravnborg <sam@ravnborg.org>
*
*
- * Don't define absolute symbols until and unless you know that symbol
- * value is should remain constant even if kernel image is relocated
- * at run time. Absolute symbols are not relocated. If symbol value should
- * change if kernel is relocated, make the symbol section relative and
+ * Don't define absolute symbols until and unless you know that the symbol
+ * value should remain constant even if the kernel image is relocated at
+ * run time. Absolute symbols are not relocated. If the symbol value should
+ * change if the kernel is relocated, make the symbol section relative and
* put it inside the section definition.
*/
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-10 16:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-02 13:25 [PATCH] x86: Clean up a tiny description mistake in kernel ld script Baoquan He
2017-02-10 11:46 ` Thomas Gleixner
2017-02-10 12:37 ` Baoquan He
2017-02-10 12:51 ` [PATCH v2] " Baoquan He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox